Force colors from mypy always, strip in pants when --no-colors #16586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
|
NB. this is exactly the removed code from #16488, without fixing the linux-specific problems described in #16488 (comment). If someone else hasn't magically solved them for me, I'll try to work through it sometime next week. |
[ci skip-rust] [ci skip-build-wheels]
|
|
stuhood
approved these changes
Sep 9, 2022
| report: Digest = EMPTY_DIGEST, | ||
| ) -> CheckResult: | ||
| def prep_output(s: bytes) -> str: | ||
| return strip_v2_chroot_path(s) if strip_chroot_path else s.decode() | ||
| chroot = strip_v2_chroot_path(s) if strip_chroot_path else s.decode() | ||
| formatting = cast(str, colors.strip_color(chroot)) if strip_formatting else chroot |
There was a problem hiding this comment.
I'm pretty sure this cast is safe, because strip_colors uses a str regex rather than a binary one?
|
Yay, thanks! |
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Sep 9, 2022
…build#16586) This fixes pantsbuild#16451 by continuing the color half of pantsbuild#16488 (terminal width). It does this by forcing mypy to always include color escapes, and then stripping them out in pants, based on the [GLOBAL].colors setting. This seems to only be possible via an undocumented environment variable: `MYPY_FORCE_COLOR`: python/mypy#7771, https://github.com/python/mypy/blob/03638dd670373db0b8f00cc3bcec256d09729d06/mypy/util.py#L543 Doing this also requires setting `TERM=linux` so that curses can find appropriate info in the terminfo database. [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Sep 9, 2022
…y-pick of #16586) (#16808) This fixes #16451 by continuing the color half of #16488 (terminal width). It does this by forcing mypy to always include color escapes, and then stripping them out in pants, based on the [GLOBAL].colors setting. This seems to only be possible via an undocumented environment variable: `MYPY_FORCE_COLOR`: python/mypy#7771, https://github.com/python/mypy/blob/03638dd670373db0b8f00cc3bcec256d09729d06/mypy/util.py#L543 Doing this also requires setting `TERM=linux` so that curses can find appropriate info in the terminfo database. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16451 by continuing the color half of #16488 (terminal width).
It does this by forcing mypy to always include color escapes, and then stripping them out in pants, based on the [GLOBAL].colors setting.
This seems to only be possible via an undocumented environment variable:
MYPY_FORCE_COLOR: python/mypy#7771, https://github.com/python/mypy/blob/03638dd670373db0b8f00cc3bcec256d09729d06/mypy/util.py#L543Doing this also requires setting
TERM=linuxso that curses can find appropriate info in the terminfo database.[ci skip-rust]
[ci skip-build-wheels]