Modloader: PTR2Hooks cleanup, minor refactor, better logs, comments

Author: pips3

pcsx2/mods/EmuPatches.cpp

@@ -2,14 +2,14 @@
 #include <pcsx2/vtlb.h>
 #include "GS/Renderers/Common/GSDevice.h"
 
-//Reactive Aspect Ratio Patch
-//This one won't be visible in UI
+// Reactive Aspect Ratio Patch
+// This one won't be visible in UI
 void PTR2AspectRatioSet(AspectRatioType ar)
 {
 	char buf[4] = {};
 	switch (ar)
 	{
-		//adapted from Parotaku's widescreen patch
+		// adapted from Parotaku's widescreen patch
 		case AspectRatioType::R4_3:
 			//patch=1,EE,0016066c,word,3c013f40
 			vtlb_memSafeWriteBytes(0x0016066c, &buf, 4);
@@ -43,9 +43,9 @@ void PTR2AspectRatioSet(AspectRatioType ar)
 				char buf[4] = {0x40, 0x3F, 0x01, 0x3C};
 				vtlb_memSafeWriteBytes(0x0016066c, &buf, 4);
 
-				//replace the "3f40" (0.75 for 16:9) with our new multiplier
-				float heightReal = height * 1.071; //to get 448 to 480
-				heightReal = heightReal * 1.25; //this number has no meaning its eyeballed 
+				// replace the "3f40" (0.75 for 16:9) with our new multiplier
+				float heightReal = height * 1.071; // to get 448 to 480
+				heightReal = heightReal * 1.25; // this number has no meaning its eyeballed 
 				float multiplier = heightReal / float(width);
 				char buf2[4] = {};
 				memcpy(buf2, &multiplier, 4);
@@ -68,9 +68,15 @@ void PTR2AspectRatioSet()
 	PTR2AspectRatioSet(ar);
 }
 
-//Patches unused func PackIntDecode to just infinitely call MTCWait(1)
-//this is so we can do stuff asynchronously by jumping to PackIntDecode
-//i.e loading INT assets ourselves without the loading screen stuttering/pausing
+// Patches unused func PackIntDecode to just infinitely call MTCWait(1)
+// this is so we can do stuff asynchronously* by jumping to PackIntDecode
+// i.e loading INT assets ourselves without the loading screen stuttering/pausing
+
+// *I don't think this is technically async, as we are copying the original game logic and just
+// sleeping** after XX milliseconds, to call MTCWait() and give the game time to render out the
+// loading screen, either way the end goal of stopping stuttering is achieved
+
+// **In our case we don't sleep, we end the hook, which lets the game start running PackIntDecode again
 
 void createAsyncFunc()
 {
@@ -82,7 +88,7 @@ void createAsyncFunc()
 		0x01, 0x00, 0x04, 0x24, // addiu a0,zero,0x1  (li a0, 0x1	 |
 		0x00, 0x00, 0x00, 0x00, // nop								 |
 		0x00, 0x00, 0xA4, 0x8F, // lw a0, (sp)						 |
-		0xFA, 0xFF, 0x80, 0x10, // beqz, a0, 0x00104E98  -------------  
+		0x00, 0x00, 0x00, 0x00, // nop                   -------------  (Gets patched to a beqz, a0, 0x00104E98 by INT_Loader hook in PTR2Hooks.cpp)
 		0x00, 0x00, 0x00, 0x00, // nop
 		0x10, 0x00, 0xA4, 0xDF, // ld a0, 0x10(sp)
 		0x0C, 0x03, 0x00, 0x10, // beq zero zero 0x00105aec
@@ -91,7 +97,7 @@ void createAsyncFunc()
 
 	vtlb_memSafeWriteBytes(0x00104e90, &buf, 48);
 
-	//patch jal PackIntDecodeWait to jal PackIntDecode
+	// patch jal PackIntDecodeWait to jal PackIntDecode
 	char buf2[4] = { 0xA4, 0x13, 0x04, 0x0C };
 	vtlb_memSafeWriteBytes(0x00105ad8, &buf2, 4);
 }