Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: softmax() got an unexpected keyword argument 'axis' #150

Open
kegl opened this issue Oct 1, 2018 · 21 comments
Open

TypeError: softmax() got an unexpected keyword argument 'axis' #150

kegl opened this issue Oct 1, 2018 · 21 comments
Assignees
@kegl @jorisvandenbossche @aboucaud @glemaitre

Comments

@kegl
Copy link
Contributor

kegl commented Oct 1, 2018

On my mac pytest (the MNIST kit) is failing with the error in the subject. I did pip install -U tensorflow. Should we modify the kit?

keras-team/keras#9621
@aboucaud
Copy link
Contributor

aboucaud commented Oct 1, 2018

Or maybe just pin the dependencies..

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

I'm not sure pinning is a good idea in this case, we should try to keep the test up with the changes. When I run pytest locally, I don't want to reinstall tensorflow each time.

@aboucaud
Copy link
Contributor

aboucaud commented Oct 1, 2018 via email

@jorisvandenbossche
Copy link
Member

Apart from the discussion about versions, is there actually something to fix? (that we can fix in the code, apart from having the correct version match of keras / tensorflow)
And where is the error coming from, from the workflow element in ramp-workflow, or from the example model included in the kit's starting kit submission?

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

My argument is that the tests in rampwf should be made up to date with the libraries. We can keep the kit itself in a virtualenv, but not rampwf itself.

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

@jorisvandenbossche the test (pytest) of ramp-workflow is failing on my mac. But I'm not sure if it's because the tensorflow version for mac is not compatible with the latest tensorflow, or the other way around, that the newest tensorflow has this feature.

@aboucaud
Copy link
Contributor

aboucaud commented Oct 1, 2018 via email

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018 

silver6:ramp-workflow kegl$ pip install -U tensorflow
Requirement already up-to-date: tensorflow in /Users/kegl/anaconda/lib/python2.7/site-packages (1.1.0)
Requirement already satisfied, skipping upgrade: six>=1.10.0 in /Users/kegl/anaconda/lib/python2.7/site-packages (from tensorflow) (1.11.0)
Requirement already satisfied, skipping upgrade: werkzeug>=0.11.10 in /Users/kegl/anaconda/lib/python2.7/site-packages (from tensorflow) (0.14.1)
Requirement already satisfied, skipping upgrade: mock>=2.0.0 in /Users/kegl/anaconda/lib/python2.7/site-packages (from tensorflow) (2.0.0)
Requirement already satisfied, skipping upgrade: numpy>=1.11.0 in /Users/kegl/anaconda/lib/python2.7/site-packages (from tensorflow) (1.15.2)
Requirement already satisfied, skipping upgrade: protobuf>=3.2.0 in /Users/kegl/anaconda/lib/python2.7/site-packages (from tensorflow) (3.5.2)
Requirement already satisfied, skipping upgrade: wheel in /Users/kegl/anaconda/lib/python2.7/site-packages (from tensorflow) (0.29.0)
Requirement already satisfied, skipping upgrade: funcsigs>=1 in /Users/kegl/anaconda/lib/python2.7/site-packages (from mock>=2.0.0->tensorflow) (1.0.2)
Requirement already satisfied, skipping upgrade: pbr>=0.11 in /Users/kegl/anaconda/lib/python2.7/site-packages (from mock>=2.0.0->tensorflow) (4.0.2)
Requirement already satisfied, skipping upgrade: setuptools in /Users/kegl/anaconda/lib/python2.7/site-packages (from protobuf>=3.2.0->tensorflow) (39.0.1)

@aboucaud
Copy link
Contributor

aboucaud commented Oct 1, 2018 via email

@jorisvandenbossche
Copy link
Member

we might also think about stopping support for Python 2.

+1

So if I remember correctly, our idea was to keep testing the kits in rampwf-kits-test-master with their specified (pinned) versions, but the embedded sample kits in ramp-workflow itself should be updated to make sure they pass in the tests for all versions of dependencies we want to support in rampwf.

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

1.1.0

@jorisvandenbossche
Copy link
Member

and which keras version?

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

2.2.0

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

updated to 2.2.2, same error

@aboucaud
Copy link
Contributor

aboucaud commented Oct 1, 2018

Ok so current version of tensorflow is 1.11.0 and has the keyword axis.
So it's more a local issue.

@jorisvandenbossche
Copy link
Member

Is it possible that the combination you have of keras and tensorflow are not compatible?

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

ok. so no solution, locally.

@aboucaud
Copy link
Contributor

aboucaud commented Oct 1, 2018

maybe try a newer version of tensorflow, like 1.8 or 1.9

pip install tensorflow==1.9.0

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

doesn't work

@jorisvandenbossche
Copy link
Member

I don't really find any documentation of keras on what versions of tensorflow they support

doesn't work

You mean that it gives the same error?

@kegl
Copy link
Contributor Author

kegl commented Oct 1, 2018

there is no version for me above 1.1

silver6:ramp-workflow kegl$ pip install tensorflow==1.2.0
Collecting tensorflow==1.2.0
  Could not find a version that satisfies the requirement tensorflow==1.2.0 (from versions: )
No matching distribution found for tensorflow==1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kegl kegl

@jorisvandenbossche jorisvandenbossche

@aboucaud aboucaud

@glemaitre glemaitre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kegl @jorisvandenbossche @aboucaud @glemaitre