Skip to content

Commit bf15643

Browse files
authored
[docs] remove invalid headers in MD, fix code size in headers (expo#20451)
1 parent 5764a17 commit bf15643

File tree

8 files changed

+32
-34
lines changed

8 files changed

+32
-34
lines changed

docs/pages/build/internal-distribution.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ EAS Build can help you with this by providing shareable URLs for your builds wit
1111

1212
> Installing an app on iOS is a bit trickier than on Android, but it's possible thanks to ad hoc and enterprise provisioning profiles. We'll talk more about this later in this doc.
1313
14-
# Setting up internal distribution
14+
## Setting up internal distribution
1515

16-
The following three steps will guide you through adding internal distribution to a project that is [already set up to build with EAS Build](setup.mdx). It will only take a few minutes in total to: configure the project, add a couple of test iOS devices to a provisioning profile, and start builds for Android and iOS.
16+
The following steps will guide you through adding internal distribution to a project that is [already set up to build with EAS Build](setup.mdx). It will only take a few minutes in total to: configure the project, add a couple of test iOS devices to a provisioning profile, and start builds for Android and iOS.
1717

1818
## 1. Configure a build profile
1919

docs/pages/eas/metadata/schema.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
title: Schema for EAS Metadata
33
sidebar_title: Metadata schema
4-
sidebar_depth: 4
4+
maxHeadingDepth: 4
55
---
66

77
import { Collapsible } from '~/ui/components/Collapsible';

docs/pages/expokit/universal-modules-and-expokit.mdx

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
22
title: Universal Modules and ExpoKit
3+
maxHeadingDepth: 4
34
---
45

56
> **warning** ExpoKit is deprecated and is no longer supported after SDK 38. If you need to make customizations to your Expo project, we recommend using the [bare workflow](../workflow/customizing.mdx) instead.
@@ -11,7 +12,7 @@ Universal Modules are pieces of the Expo SDK with some special properties:
1112

1213
Not all Expo SDK modules are Universal Modules. Right now, only a small part of our SDK has this property. We're continually expanding the number of our APIs that are available as universal modules.
1314

14-
# Omitting Unneeded Modules
15+
## Omitting Unneeded Modules
1516

1617
When you [create an ExpoKit project](eject.mdx), we automatically add most of the same native APIs that are available in the Expo Go app. Each of these APIs is supported by some native code which increases the size of your native binary.
1718

@@ -21,17 +22,17 @@ Omitting Universal Modules is currently supported on iOS but not Android.
2122

2223
> **If you aren't sure what this guide is for or whether you need this,** you are probably better off just leaving it alone. Otherwise you risk causing crashes in your app by ripping out needed APIs.
2324
24-
## iOS
25+
### iOS
2526

2627
To omit a Universal Module from your iOS ExpoKit project, remove the respective dependency from `ios/Podfile`. Then re-run `npx pod-install` and rebuild your native code.
2728

28-
### These modules are included by default, but can be omitted
29+
#### These modules are included by default, but can be omitted
2930

3031
- GL (`EXGL` and `EXGL-CPP`)
3132
- SMS composer (`EXSMS`)
3233
- Accelerometer, DeviceMotion, Gyroscope, Magnetometer, Pedometer (`EXSensors`)
3334

34-
### These modules are included by default, but can be dangerously omitted
35+
#### These modules are included by default, but can be dangerously omitted
3536

3637
Some modules implement core Expo functionality through a generic interface. For example, our `Permissions` module implements `expo-permissions-interface`. If you remove the Permissions module, the project will build, but it may not run unless you add some other code which provides Expo Permissions functionality.
3738

@@ -40,11 +41,7 @@ Some modules implement core Expo functionality through a generic interface. For
4041
- FileSystem (`EXFileSystem`)
4142
- Permissions (`EXPermissions`)
4243

43-
## Android
44-
45-
Omitting Universal Modules is not currently supported on Android.
46-
47-
# Adding Optional Modules on iOS
44+
#### Adding Optional Modules
4845

4946
A few Expo modules are not included by default in ExpoKit iOS projects, nor in Standalone iOS Apps produced by `expo build`. Typically this is either because they add a disproportionate amount of bloat to the binary, or because they include APIs that are governed by extra Apple review guidelines. Right now those modules are:
5047

@@ -61,3 +58,8 @@ To add FaceDetector:
6158
3. Re-run `npx pod-install`.
6259

6360
To add `Payments` or `AR`, add the [respective subspec](https://github.com/expo/expo/blob/sdk-38/ExpoKit.podspec) to your `ExpoKit` dependency in your `Podfile`, and re-run `npx pod-install`.
61+
62+
63+
### Android
64+
65+
Omitting Universal Modules is not currently supported on Android.

docs/pages/versions/unversioned/sdk/auth-session.mdx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,7 @@ You can test it to ensure it works like this:
5050

5151
### Usage in standalone apps
5252

53-
**app.json**
54-
55-
```json
53+
```json app.json
5654
{
5755
"expo": {
5856
"scheme": "mycoolredirect"
@@ -99,7 +97,7 @@ If you are authenticating with a popular social provider, when you are ready to
9997

10098
**Never put any secret keys inside of your app, there is no secure way to do this!** Instead, you should store your secret key(s) on a server and expose an endpoint that makes API calls for your client and passes the data back.
10199

102-
# API
100+
## API
103101

104102
```js
105103
import * as AuthSession from 'expo-auth-session';

docs/pages/versions/v45.0.0/sdk/auth-session.mdx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ You can test it to ensure it works like this:
4747

4848
### Usage in standalone apps
4949

50-
**app.json**
51-
52-
```json
50+
```json app.json
5351
{
5452
"expo": {
5553
"scheme": "mycoolredirect"
@@ -96,7 +94,7 @@ If you are authenticating with a popular social provider, when you are ready to
9694

9795
**Never put any secret keys inside of your app, there is no secure way to do this!** Instead, you should store your secret key(s) on a server and expose an endpoint that makes API calls for your client and passes the data back.
9896

99-
# API
97+
## API
10098

10199
```js
102100
import * as AuthSession from 'expo-auth-session';

docs/pages/versions/v46.0.0/sdk/auth-session.mdx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@ You can test it to ensure it works like this:
4848

4949
### Usage in standalone apps
5050

51-
**app.json**
52-
53-
```json
51+
```json app.json
5452
{
5553
"expo": {
5654
"scheme": "mycoolredirect"
@@ -97,7 +95,7 @@ If you are authenticating with a popular social provider, when you are ready to
9795

9896
**Never put any secret keys inside of your app, there is no secure way to do this!** Instead, you should store your secret key(s) on a server and expose an endpoint that makes API calls for your client and passes the data back.
9997

100-
# API
98+
## API
10199

102100
```js
103101
import * as AuthSession from 'expo-auth-session';

docs/pages/versions/v47.0.0/sdk/auth-session.mdx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,7 @@ You can test it to ensure it works like this:
5050

5151
### Usage in standalone apps
5252

53-
**app.json**
54-
55-
```json
53+
```json app.json
5654
{
5755
"expo": {
5856
"scheme": "mycoolredirect"
@@ -99,7 +97,7 @@ If you are authenticating with a popular social provider, when you are ready to
9997

10098
**Never put any secret keys inside of your app, there is no secure way to do this!** Instead, you should store your secret key(s) on a server and expose an endpoint that makes API calls for your client and passes the data back.
10199

102-
# API
100+
## API
103101

104102
```js
105103
import * as AuthSession from 'expo-auth-session';

docs/ui/components/Text/index.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,16 @@ export const kbdStyle = css({
8888
top: -1,
8989
});
9090

91-
export const H1 = createTextComponent(TextElement.H1, css(typography.headers.default.h1));
92-
export const H2 = createTextComponent(TextElement.H2, css(typography.headers.default.h2));
93-
export const H3 = createTextComponent(TextElement.H4, css(typography.headers.default.h3));
94-
export const H4 = createTextComponent(TextElement.H4, css(typography.headers.default.h4));
95-
export const H5 = createTextComponent(TextElement.H5, css(typography.headers.default.h5));
96-
export const H6 = createTextComponent(TextElement.H6, css(typography.headers.default.h6));
91+
const codeInHeaderStyle = { '& code': { fontSize: 'inherit' } };
92+
93+
const { h1, h2, h3, h4, h5, h6 } = typography.headers.default;
94+
export const H1 = createTextComponent(TextElement.H1, css([h1, codeInHeaderStyle]));
95+
export const H2 = createTextComponent(TextElement.H2, css([h2, codeInHeaderStyle]));
96+
export const H3 = createTextComponent(TextElement.H3, css([h3, codeInHeaderStyle]));
97+
export const H4 = createTextComponent(TextElement.H4, css([h4, codeInHeaderStyle]));
98+
export const H5 = createTextComponent(TextElement.H5, css([h5, codeInHeaderStyle]));
99+
export const H6 = createTextComponent(TextElement.H6, css([h6, codeInHeaderStyle]));
100+
97101
export const P = createTextComponent(TextElement.P, css(typography.body.paragraph));
98102
export const CODE = createTextComponent(
99103
TextElement.CODE,

0 commit comments

Comments
 (0)