From 10b87ec8618eccdbad464307c50df014ce2f6361 Mon Sep 17 00:00:00 2001
From: Xavier Le Cunff <xavier.lecunff@passculture.app>
Date: Mon, 10 Feb 2025 12:47:26 +0100
Subject: [PATCH] feat: delete diff script

---
 .../workflows/dev_on_push_workflow_main.yml   |  2 +-
 ...yml => dev_on_workflow_check_deadcode.yml} |  2 +-
 scripts/check_dead_code_introduced.sh         | 46 -------------------
 3 files changed, 2 insertions(+), 48 deletions(-)
 rename .github/workflows/{dev_on_workflow_ts_prune.yml => dev_on_workflow_check_deadcode.yml} (95%)
 delete mode 100755 scripts/check_dead_code_introduced.sh

diff --git a/.github/workflows/dev_on_push_workflow_main.yml b/.github/workflows/dev_on_push_workflow_main.yml
index f7a95ee43de..f6cd05cf8bd 100644
--- a/.github/workflows/dev_on_push_workflow_main.yml
+++ b/.github/workflows/dev_on_push_workflow_main.yml
@@ -72,7 +72,7 @@ jobs:
       GCP_EHP_WORKLOAD_IDENTITY_PROVIDER: ${{ secrets.GCP_EHP_WORKLOAD_IDENTITY_PROVIDER }}
   yarn-ts-prune:
     needs: yarn-install
-    uses: ./.github/workflows/dev_on_workflow_ts_prune.yml
+    uses: ./.github/workflows/dev_on_workflow_check_deadcode.yml
     with:
       CACHE_BUCKET_NAME: passculture-infra-prod-github-runner-cache
     secrets:
diff --git a/.github/workflows/dev_on_workflow_ts_prune.yml b/.github/workflows/dev_on_workflow_check_deadcode.yml
similarity index 95%
rename from .github/workflows/dev_on_workflow_ts_prune.yml
rename to .github/workflows/dev_on_workflow_check_deadcode.yml
index 52e4405a48e..b55500b7df7 100644
--- a/.github/workflows/dev_on_workflow_ts_prune.yml
+++ b/.github/workflows/dev_on_workflow_check_deadcode.yml
@@ -36,4 +36,4 @@ jobs:
           restore-keys: |
             v1-yarn-dependency-cache-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
       - name: Run script for dead code check
-        run: ./scripts/check_dead_code_introduced.sh
+        run: yarn test:deadcode
diff --git a/scripts/check_dead_code_introduced.sh b/scripts/check_dead_code_introduced.sh
deleted file mode 100755
index d0d3e03b23a..00000000000
--- a/scripts/check_dead_code_introduced.sh
+++ /dev/null
@@ -1,46 +0,0 @@
-#!/usr/bin/env bash
-
-set -o errexit
-set -o nounset
-set -o pipefail
-
-yarn test:deadcode >scripts/dead_code_current.txt
-
-current_dead_code_count=$(wc -l <scripts/dead_code_current.txt)
-snapshot_dead_code_count=$(wc -l <scripts/dead_code_snapshot.txt)
-diff_dead_code_count=$((current_dead_code_count - snapshot_dead_code_count))
-
-function display_differences_between_dead_code() {
-    diff --color=auto --unified scripts/dead_code_snapshot.txt scripts/dead_code_current.txt
-}
-
-function how_to_update_snapshot() {
-    echo 'If you have `(used in module)` that means that you probably have a useless `export`'
-    echo '⏺️ Please run `yarn test:deadcode:update`'
-    echo 'More informations https://en.wikipedia.org/wiki/Software_testing#Output_comparison_testing'
-}
-
-if [ "$diff_dead_code_count" -lt 0 ]; then
-    echo "✅ The dead code has decreased:"
-    display_differences_between_dead_code || {
-        echo '👏 This means that you have deleted more dead code than you potentially introduced'
-        echo '👀 Check that you have not introduced a new dead code'
-        how_to_update_snapshot
-        exit 1
-    }
-elif [ "$diff_dead_code_count" -gt 0 ]; then
-    echo "❌ The dead code has increased:"
-    display_differences_between_dead_code || {
-        echo '👀 If the increase of the dead code is legit and you tried to update the configuration of ts-prune to ignore it but it does not work 😣'
-        how_to_update_snapshot
-        exit 1
-    }
-else
-    echo "⬜ The dead code seems unchanged."
-    display_differences_between_dead_code || {
-        echo '👏 This means that you have deleted dead code as much as you have introduced new dead code'
-        echo '👀 If the introduced dead code is legit and you tried to update the configuration of ts-prune to ignore it but it does not work 😣'
-        how_to_update_snapshot
-        exit 1
-    }
-fi