featureless refactors

Author: barrymichaeldoyle

eslint.config.ts

@@ -45,6 +45,7 @@ export default [
       'no-console': 'off', // Allow console.log for CLI output
       'prefer-const': 'error',
       'no-var': 'error',
+      'func-style': ['error', 'declaration', { allowArrowFunctions: false }],
 
       // Code quality (non-formatting - formatting handled by Prettier)
       eqeqeq: ['error', 'always'],
@@ -54,7 +55,5 @@ export default [
       'no-script-url': 'error',
     },
   },
-  {
-    ignores: ['dist/', 'lib/', 'node_modules/', '*.js', '*.d.ts', 'scripts/'],
-  },
+  { ignores: ['dist/', 'lib/', 'node_modules/', '*.js', '*.d.ts', 'scripts/'] },
 ];

package-lock.json

@@ -64,7 +64,7 @@
     "@vitest/coverage-v8": "3.2.4",
     "eslint": "9.29.0",
     "eslint-config-prettier": "10.1.5",
-    "eslint-plugin-prettier": "5.5.0",
+    "eslint-plugin-prettier": "5.5.1",
     "jiti": "2.4.2",
     "prettier": "3.6.1",
     "tsx": "4.20.3",

package.json

@@ -0,0 +1,8 @@
+import { type PackageManager } from './types';
+
+export const PACKAGE_MANAGERS: readonly PackageManager[] = [
+  'npm',
+  'pnpm',
+  'yarn',
+  'bun',
+];

src/constant.ts

@@ -47,9 +47,12 @@ export async function checkDependencyVersions(
           isOutdated = false;
           updateType = undefined;
         } else if (latestVersion) {
-          isOutdated = isVersionOutdated(version, latestVersion);
+          isOutdated = isVersionOutdated({
+            current: version,
+            latest: latestVersion,
+          });
           updateType = isOutdated
-            ? getUpdateType(version, latestVersion)
+            ? getUpdateType({ current: version, latest: latestVersion })
             : undefined;
         }
       }

src/core/dependency-checker.ts

@@ -11,7 +11,7 @@ import {
   getPackageManagerInfo,
   updateDependencies,
 } from './services/package-manager';
-import { type DependencyInfo } from './types';
+import { type DependencyInfo, type UpdateableDependency } from './types';
 import { displayHelp } from './ui/display/help';
 import { displayLicense } from './ui/display/license';
 import { displaySummary } from './ui/display/summary';
@@ -71,23 +71,14 @@ async function main(): Promise<void> {
           : detectPackageManager();
 
         // Show update prompt
-        const updateType = await displayUpdatePrompt(
-          allDependencies,
-          packageManager
-        );
+        const updateType = await displayUpdatePrompt(allDependencies);
 
         if (updateType) {
           const outdatedDeps = allDependencies.filter(
             d => d.isOutdated && !d.isSkipped
           );
 
-          let depsToUpdate: Array<{
-            packageName: string;
-            currentVersion: string;
-            latestVersion: string;
-            updateType: 'patch' | 'minor' | 'major';
-            category: string;
-          }> = [];
+          let depsToUpdate: UpdateableDependency[] = [];
 
           if (updateType === 'patch') {
             depsToUpdate = outdatedDeps
@@ -126,7 +117,10 @@ async function main(): Promise<void> {
           }
 
           if (depsToUpdate.length > 0) {
-            await updateDependencies(depsToUpdate, packageManager);
+            await updateDependencies({
+              dependencies: depsToUpdate,
+              packageManager,
+            });
           }
         }
       }
@@ -167,23 +161,23 @@ const validFlags = [
   '--update-prompt',
   '--no-update-prompt',
 ];
-const unknownArgs = getUnknownArgs(args, validFlags);
+const unknownArgs = getUnknownArgs({ args, validFlags });
 if (unknownArgs.length > 0) {
   displayUnknownArguments(unknownArgs);
   process.exit(1);
 }
 
-if (hasAnyFlag(args, ['--help', '-h', '--info', '-i'])) {
+if (hasAnyFlag({ args, flags: ['--help', '-h', '--info', '-i'] })) {
   displayHelp();
   process.exit(0);
 }
 
-if (hasAnyFlag(args, ['--version', '-v'])) {
+if (hasAnyFlag({ args, flags: ['--version', '-v'] })) {
   displayVersion();
   process.exit(0);
 }
 
-if (hasAnyFlag(args, ['--license', '-l'])) {
+if (hasAnyFlag({ args, flags: ['--license', '-l'] })) {
   displayLicense();
   process.exit(0);
 }

src/index.ts

@@ -6,12 +6,10 @@ import {
   getPackageManagerInfo,
 } from '../package-manager';
 
-// Mock fs module
 vi.mock('fs', () => ({
   existsSync: vi.fn(),
 }));
 
-// Mock path module
 vi.mock('path', () => ({
   join: vi.fn(),
 }));
@@ -26,12 +24,12 @@ describe('package-manager', () => {
       const mockExistsSync = vi.mocked(existsSync);
       const mockJoin = vi.mocked(join);
 
-      mockJoin.mockImplementation((dir: string, file: string) => {
-        return `${dir}/${file}`;
-      });
-      mockExistsSync.mockImplementation((path: any) => {
-        return path === '/test/package-lock.json';
-      });
+      mockJoin.mockImplementation(
+        (dir: string, file: string) => `${dir}/${file}`
+      );
+      mockExistsSync.mockImplementation(
+        path => path === '/test/package-lock.json'
+      );
 
       const result = detectPackageManager('/test');
 
@@ -46,12 +44,12 @@ describe('package-manager', () => {
       const mockExistsSync = vi.mocked(existsSync);
       const mockJoin = vi.mocked(join);
 
-      mockJoin.mockImplementation((dir: string, file: string) => {
-        return `${dir}/${file}`;
-      });
-      mockExistsSync.mockImplementation((path: any) => {
-        return path === '/test/pnpm-lock.yaml';
-      });
+      mockJoin.mockImplementation(
+        (dir: string, file: string) => `${dir}/${file}`
+      );
+      mockExistsSync.mockImplementation(
+        path => path === '/test/pnpm-lock.yaml'
+      );
 
       const result = detectPackageManager('/test');
 
@@ -66,12 +64,10 @@ describe('package-manager', () => {
       const mockExistsSync = vi.mocked(existsSync);
       const mockJoin = vi.mocked(join);
 
-      mockJoin.mockImplementation((dir: string, file: string) => {
-        return `${dir}/${file}`;
-      });
-      mockExistsSync.mockImplementation((path: any) => {
-        return path === '/test/yarn.lock';
-      });
+      mockJoin.mockImplementation(
+        (dir: string, file: string) => `${dir}/${file}`
+      );
+      mockExistsSync.mockImplementation(path => path === '/test/yarn.lock');
 
       const result = detectPackageManager('/test');
 
@@ -86,12 +82,10 @@ describe('package-manager', () => {
       const mockExistsSync = vi.mocked(existsSync);
       const mockJoin = vi.mocked(join);
 
-      mockJoin.mockImplementation((dir: string, file: string) => {
-        return `${dir}/${file}`;
-      });
-      mockExistsSync.mockImplementation((path: any) => {
-        return path === '/test/bun.lockb';
-      });
+      mockJoin.mockImplementation(
+        (dir: string, file: string) => `${dir}/${file}`
+      );
+      mockExistsSync.mockImplementation(path => path === '/test/bun.lockb');
 
       const result = detectPackageManager('/test');
 

src/services/__tests__/package-manager.test.ts

@@ -1,6 +1,7 @@
 import { existsSync, readFileSync } from 'fs';
 import { join } from 'path';
-import { type PackageManager } from './package-manager';
+import { PACKAGE_MANAGERS } from '../constant';
+import { type PackageManager } from '../types';
 
 export interface PatchPulseConfig {
   skip?: string[];
@@ -77,8 +78,9 @@ export function parseCliConfig(args: string[]): PatchPulseConfig {
   if (packageManagerIndex !== -1 && packageManagerIndex + 1 < args.length) {
     const packageManagerValue = args[packageManagerIndex + 1];
     if (!packageManagerValue.startsWith('-')) {
-      if (['npm', 'pnpm', 'yarn', 'bun'].includes(packageManagerValue)) {
-        config.packageManager = packageManagerValue as any;
+      const typeSafePackageManager = packageManagerValue as PackageManager;
+      if (PACKAGE_MANAGERS.includes(typeSafePackageManager)) {
+        config.packageManager = typeSafePackageManager;
       }
     }
   }

src/services/config.ts

@@ -2,10 +2,9 @@ import chalk from 'chalk';
 import { spawn } from 'child_process';
 import { existsSync } from 'fs';
 import { join } from 'path';
+import { type PackageManager, type UpdateableDependency } from '../types';
 import { pluralize } from '../utils/pluralize';
 
-export type PackageManager = 'npm' | 'pnpm' | 'yarn' | 'bun';
-
 export interface PackageManagerInfo {
   name: PackageManager;
   lockFiles: string[];
@@ -103,30 +102,26 @@ export function runPackageManagerCommand(
 /**
  * Updates dependencies based on update type
  * @param dependencies - Array of dependencies to update
- * @param updateType - The type of update to perform ('patch', 'minor', 'all')
  * @param packageManager - The package manager to use
  * @returns Promise that resolves when all updates are complete
  */
-export async function updateDependencies(
-  dependencies: Array<{
-    packageName: string;
-    currentVersion: string;
-    latestVersion: string;
-    updateType: 'patch' | 'minor' | 'major';
-    category: string;
-  }>,
-  packageManager: PackageManagerInfo
-): Promise<void> {
+export async function updateDependencies({
+  dependencies,
+  packageManager,
+}: {
+  dependencies: UpdateableDependency[];
+  packageManager: PackageManagerInfo;
+}): Promise<void> {
   if (dependencies.length === 0) {
     console.log(chalk.yellow('No dependencies to update'));
     return;
   }
 
-  const dependencyWord = pluralize(
-    dependencies.length,
-    'dependency',
-    'dependencies'
-  );
+  const dependencyWord = pluralize({
+    count: dependencies.length,
+    singular: 'dependency',
+    plural: 'dependencies',
+  });
 
   console.log(
     chalk.cyan(

src/services/package-manager.ts

@@ -1,3 +1,5 @@
+export type PackageManager = 'npm' | 'pnpm' | 'yarn' | 'bun';
+
 export interface PackageJson {
   dependencies?: Record<string, string>;
   devDependencies?: Record<string, string>;
@@ -16,6 +18,18 @@ export interface DependencyInfo {
   category?: string;
 }
 
+/**
+ * A dependency that is guaranteed to have latestVersion and updateType fields
+ * Used for dependencies that have been filtered and validated for updates
+ */
+export interface UpdateableDependency {
+  packageName: string;
+  currentVersion: string;
+  latestVersion: string;
+  updateType: 'patch' | 'minor' | 'major';
+  category: string;
+}
+
 export interface NpmPackageInfo {
   'dist-tags': {
     latest: string;