Skip to content

Feature Request: Add Ability To Config Name of Pattern Folder #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sghoweri opened this issue Nov 2, 2017 · 1 comment
Closed

Feature Request: Add Ability To Config Name of Pattern Folder #151

sghoweri opened this issue Nov 2, 2017 · 1 comment

Comments

@sghoweri
Copy link
Contributor

sghoweri commented Nov 2, 2017

**or multiple pattern folders if we find this work could be more valuable combining it with the other work relating to support for multiple source directories (... I might just take that on now that I'm thinking about it)

In any case, there's litterally just 3 places in the code referencing "_patterns" - seems silly imho to require crazy symlinks or Gulp copy work -- just let us specify a different patternDir folder name and default to _patterns otherwise:

https://github.com/pattern-lab/patternlab-php-core/search?utf8=✓&q=_patterns&type=

@EvanLovely @aleksip thoughts?

@EvanLovely
Copy link
Member

Agreed. I’d like to get a paths object that is similar to the node version so we can specify the folder for all of them: patterns, data, meta, etc. This is covered by #35 and is on the roadmap so I’ll close this down.

PS SourceDir as an array is #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants