Skip to content

Commit cbf373d

Browse files
Merge pull request #640 from amarie401/canvas-to-component
fix(Canvas): Canvas directive to component implementation
2 parents 75b6a78 + b6b0f81 commit cbf373d

14 files changed

+724
-781
lines changed

src/canvas-view/canvas-editor/canvas-editor.component.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
angular.module('patternfly.canvas').component('pfCanvasEditor', {
55

66
bindings: {
7-
chartDataModel: "=",
8-
chartViewModel: "=?",
9-
toolboxTabs: "=",
7+
chartDataModel: '=',
8+
chartViewModel: '=?',
9+
toolboxTabs: '=',
1010
readOnly: '<?'
1111
},
1212
transclude: true,
13-
templateUrl: "canvas-view/canvas-editor/canvas-editor.html",
13+
templateUrl: 'canvas-view/canvas-editor/canvas-editor.html',
1414
controller: function ($timeout) {
1515
var ctrl = this;
1616
var newNodeCount = 0;
@@ -59,8 +59,8 @@
5959
// focus to filter input box
6060

6161
$timeout(function () {
62-
angular.element(".subtabs>ul").addClass('nav-tabs-pf');
63-
angular.element("#filterFld").focus();
62+
angular.element('.subtabs>u').addClass('nav-tabs-pf');
63+
angular.element('#filterFld').focus();
6464
});
6565
};
6666

@@ -79,7 +79,7 @@
7979
};
8080

8181
ctrl.tabClicked = function () {
82-
angular.element("#filterFld").focus();
82+
angular.element('#filterFld').focus();
8383
};
8484

8585
/*** Toolbox ***/
@@ -109,7 +109,7 @@
109109
};
110110

111111
ctrl.tabClicked = function () {
112-
angular.element("#filterFld").focus();
112+
angular.element('#filterFld').focus();
113113
};
114114

115115
ctrl.activeTab = function () {
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
(function () {
2+
'use strict';
3+
4+
angular.module('patternfly.canvas')
5+
.component('toolboxItems', {
6+
templateUrl: 'canvas-view/canvas-editor/toolbox-items.html',
7+
bindings: {
8+
items: '=',
9+
startDragCallback: '<',
10+
clickCallback: '<',
11+
searchText: '='
12+
},
13+
controller: function toolboxItemsController () {
14+
var ctrl = this;
15+
16+
ctrl.itemClicked = function (item) {
17+
if (angular.isFunction(ctrl.clickCallback) && !item.disableInToolbox) {
18+
ctrl.clickCallback(item);
19+
}
20+
};
21+
22+
ctrl.startItemDrag = function (event, ui, item) {
23+
if (angular.isFunction(ctrl.startDragCallback)) {
24+
ctrl.startDragCallback(event, ui, item);
25+
}
26+
};
27+
}
28+
});
29+
})();

src/canvas-view/canvas-editor/toolbox-items.directive.js

-39
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<ul class="toolbox-items-list">
2-
<li class="toolbox-item" ng-repeat="item in vm.items | filter:vm.searchText"
3-
data-drag="{{!item.disableInToolbox}}" jqyoui-draggable="{onStart:'vm.startDragCallbackfmDir(item)'}"
4-
ng-class="{'not-draggable': item.disableInToolbox}"
5-
data-jqyoui-options="{revert: 'invalid', helper: 'clone'}"
6-
ng-click="vm.clickCallbackfmDir(item)"
7-
uib-tooltip="{{(item.disableInToolbox ? 'Items cannot be added to the canvas more than once.' : '')}}">
8-
<img ng-if="item.image" src="{{item.image}}" alt="{{item.name}}"/>
9-
<i ng-if="item.icon && !item.image" class="draggable-item-icon {{item.icon}}"></i>
10-
<span>{{ item.name }}</span>
11-
</li>
2+
<li class="toolbox-item" ng-repeat="item in $ctrl.items | filter:$ctrl.searchText"
3+
data-drag="{{!item.disableInToolbox}}" jqyoui-draggable="{onStart:'$ctrl.startDragCallbackfmDir(item)'}"
4+
ng-class="{'not-draggable': item.disableInToolbox}"
5+
data-jqyoui-options="{revert: 'invalid', helper: 'clone'}"
6+
ng-click="$ctrl.clickCallbackfmDir(item)"
7+
uib-tooltip="{{(item.disableInToolbox ? 'Items cannot be added to the canvas more than once.' : '')}}">
8+
<img ng-if="item.image" src="{{item.image}}" alt="{{item.name}}"/>
9+
<i ng-if="item.icon && !item.image" class="draggable-item-icon {{item.icon}}"></i>
10+
<span>{{ item.name }}</span>
11+
</li>
1212
</ul>

0 commit comments

Comments
 (0)