Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: static version property not set correctly #1885

Open
bennypowers opened this issue Feb 24, 2022 · 1 comment
Open

tools: static version property not set correctly #1885

bennypowers opened this issue Feb 24, 2022 · 1 comment
Assignees
@bennypowers
Labels
priority: low Severity level: 3 release Tags for any PR related to a release

Comments

@bennypowers
Copy link
Member

bennypowers commented Feb 24, 2022 •
edited
Loading

Description of the issue

pfe-tools' packageVersion esbuild plugin reads the package.json version and interpolates it into each component's source code. The problem is that this appears to happen before the npm version command which actually updates the package.json version.
👀 👉 see chat thread, this may only be an issue for docs

Impacted component(s)

  • all

Steps to reproduce

  1. publish a package version

Expected behavior

el.constructor.version should match the package.json version
@bennypowers bennypowers added priority: low Severity level: 3 release Tags for any PR related to a release labels Feb 24, 2022
@bennypowers bennypowers self-assigned this Feb 24, 2022
@bennypowers
Copy link
Member Author

h/t @zeroedin for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennypowers bennypowers

Labels
priority: low Severity level: 3 release Tags for any PR related to a release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bennypowers