Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: mock fetch call in pfe-icon #1946

Open
bennypowers opened this issue Mar 21, 2022 · 0 comments
Open

tests: mock fetch call in pfe-icon #1946

bennypowers opened this issue Mar 21, 2022 · 0 comments
Assignees
Labels
priority: low Severity level: 3

Comments

@bennypowers
Copy link
Member

Description of the issue

tests involving pfe-icon are likely to actually fetch icon files from redhat production servers.

pfe-tools/test-runner should mock fetch to return local files for pfe-icons

Impacted component(s)

  • anything using pfe-icon

Steps to reproduce

  1. Run tests in CI
  2. tests may fail with timeouts

Expected behavior

tests do not time out or make network calls

@bennypowers bennypowers added the priority: low Severity level: 3 label Mar 21, 2022
@bennypowers bennypowers self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Severity level: 3
Projects
None yet
Development

No branches or pull requests

1 participant