Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pfe-button]: color context design spec #1996

Open
brianferry opened this issue Apr 12, 2022 · 3 comments
Open

[pfe-button]: color context design spec #1996

brianferry opened this issue Apr 12, 2022 · 3 comments
Labels
accessibility Improve accessibility needs design specs priority: low Severity level: 3

Comments

@brianferry
Copy link
Collaborator

Description of the issue

The pfe-button component does not switch colors when the parent has a color-palette of "darker" or "darkest". This is in contrast to the guidelines on Red Hat UX's site and we will want to revisit whether or not this is expected behavior for the patternfly elements button components.
@brianferry brianferry added the priority: low Severity level: 3 label Apr 12, 2022
@brianferry
Copy link
Collaborator Author

As per our discussion we do not think that we need to mimic the Red Hat design doc completely but want to make sure that what is there is the expected behavior.

@bennypowers
Copy link
Member

#1976 partially addresses this, but we need some design direction. When that PR is merged, let's rename this issue to [pfe-button]: color context design spec or some such

cc @markcaron

@brianferry brianferry changed the title pfe-button not changing colors when changing to dark mode [pfe-button]: color context design spec Apr 13, 2022
@bennypowers
Copy link
Member

See also #1997 and #2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Improve accessibility needs design specs priority: low Severity level: 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bennypowers @brianferry