Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1:1]: pfe-autocomplete => pf-search-input #2115

Open
bennypowers opened this issue Aug 25, 2022 · 2 comments
Open

[1:1]: pfe-autocomplete => pf-search-input #2115

bennypowers opened this issue Aug 25, 2022 · 2 comments
Labels
1:1 Aligning components with PatternFly v4
Milestone
PatternFly Elemen...

Comments

@bennypowers
Copy link
Member

Component name: <pfe-autocomplete>

pfe-autocomplete will be renamed to <pfe-search-input>

<rh-autocomplete> may be implemented based on search input.

Design Spec

PatternFly v4 Search Input
@bennypowers bennypowers added the 1:1 Aligning components with PatternFly v4 label Aug 25, 2022
@bennypowers bennypowers added this to the PatternFly 1:1 milestone Aug 25, 2022
@bennypowers bennypowers changed the title [1:1]: <pfe-autocomplete> => <pfe-search-input> [1:1]: pfe-autocomplete => pfe-search-input Aug 26, 2022
@bennypowers bennypowers mentioned this issue Jan 1, 2023
Closed
@github-actions github-actions bot mentioned this issue Mar 2, 2023
Merged
@zeroedin zeroedin mentioned this issue Mar 28, 2023
Open
57 tasks
@bennypowers
Copy link
Member Author

Give this a read when it comes time to implement, so that we might try to align our APIs to the <search> spec as much as possible https://www.scottohara.me/blog/2023/03/24/search-element.html

@bennypowers
Copy link
Member Author

Can we defer this and do it after we implement Text Input?

@bennypowers bennypowers moved this from Todo to Backlog in Red Hat Design System Oct 18, 2023
@bennypowers bennypowers changed the title [1:1]: pfe-autocomplete => pfe-search-input [1:1]: pfe-autocomplete => pf-search-input Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1:1 Aligning components with PatternFly v4
Projects
None yet
Milestone
PatternFly Elements 5
Development

No branches or pull requests
2 participants
@bennypowers @markcaron