Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] tests broken for tabs #2683

Closed
zeroedin opened this issue Jan 22, 2024 · 0 comments · Fixed by #2684
Closed

[bug] tests broken for tabs #2683

zeroedin opened this issue Jan 22, 2024 · 0 comments · Fixed by #2684
Assignees
Labels

Comments

@zeroedin
Copy link
Collaborator

zeroedin commented Jan 22, 2024

Wasn't quite finished working on fixing tabs tests when a PR was merged. main branch now has the broken test and ❌ on test build.

Will close this issue with a new PR.

elements/pf-tabs/test/pf-tabs.spec.ts:159:14 - error TS18048: 'snapshot.children' is possibly 'undefined'.

159       expect(snapshot.children.find(x => x.role === 'tabpanel')?.name).to.equal('Database');
                 ~~~~~~~~~~~~~~~~~

elements/pf-tabs/test/pf-tabs.spec.ts:175:13 - error TS2488: Type 'A11yTreeSnapshot[] | undefined' must have a '[Symbol.iterator]()' method that returns an iterator.

175       const [disabledTab] = snapshot.children;
                ~~~~~~~~~~~~~

elements/pf-tabs/test/pf-tabs.spec.ts:176:51 - error TS7006: Parameter 'x' implicitly has an 'any' type.

176       const tabButton = disabledTab.children.find(x => x.role === 'button')!;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant