Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tabs): lint #2684

Merged
merged 2 commits into from
Jan 23, 2024
Merged

test(tabs): lint #2684

merged 2 commits into from
Jan 23, 2024

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Jan 22, 2024 •
edited
Loading

What I did

  1. Fixed tabs tests

Closes #2683

Testing Instructions

Notes to Reviewers

@zeroedin zeroedin requested a review from bennypowers January 22, 2024 21:17
@zeroedin zeroedin self-assigned this Jan 22, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f88bb43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the tests Related to testing label Jan 22, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2024 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 3ae2956
😎 Deploy Preview https://deploy-preview-2684--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 22, 2024
@bennypowers bennypowers enabled auto-merge (squash) January 23, 2024 04:03
@bennypowers bennypowers merged commit f538d08 into main Jan 23, 2024
18 checks passed
@bennypowers bennypowers deleted the fix/tabs/test-lint branch January 23, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennypowers bennypowers bennypowers approved these changes

Assignees

@zeroedin zeroedin

Labels
AT passed Automated testing has passed ready to merge tests Related to testing
Projects
Workflow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] tests broken for tabs
2 participants
@zeroedin @bennypowers