Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabsController should not make assumptions about host's DOM #2695

Closed
bennypowers opened this issue Feb 14, 2024 · 0 comments · Fixed by #2699
Closed

TabsController should not make assumptions about host's DOM #2695

bennypowers opened this issue Feb 14, 2024 · 0 comments · Fixed by #2699

Comments

@bennypowers
Copy link
Member

bennypowers commented Feb 14, 2024

In TabsController's #rebuild() method:

const tabSlot = this.#element.shadowRoot?.querySelector<HTMLSlotElement>('slot[name=tab]');
const panelSlot = this.#element.shadowRoot?.querySelector<HTMLSlotElement>('slot:not([name])');

In order that tabs controller be applicable to any tabs implementation, these should be replaced with getter functions in the options.

We should also consider removing the dependency on expand / disabled events and the active property in a similar manner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant