⚠️ No Changeset found

Latest commit: 0ef98b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

✅ Deploy Preview for patternfly-elements ready!

To edit notification comments on pull requests, go to your Netlify site settings.

✅ Deploy Preview for patternfly-elements ready!

Name	Link
🔨 Latest commit	0ef98b8
🔍 Latest deploy log	https://app.netlify.com/sites/patternfly-elements/deploys/65ef039612e90200084f3bc3
😎 Deploy Preview	https://deploy-preview-2701--patternfly-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pf-select-group has a border bottom creating the illusion of a double border when the hr appears after it

Can we just consider that an antipattern, then?

pf-select-group has a border bottom creating the illusion of a double border when the hr appears after it

Can we just consider that an antipattern, then?

So if I understand correctly, <hr> is slotted with <pf-option> but when an <pf-option-group> is used you don't need to add the <hr> manually.

I feel like the use case is different enough to have a different expectation on the implementation. pf-option-group is an explicit pattern and grouping, where as the <hr> between <pf-option> is an additive visual reference of a perceived separation, but technically all the options are still the same "group".

@nikkimk don't forget the gh approval, plznthx