Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<pf-button>: keyboard accessibility using spacebar key #2715

Closed
nikkimk opened this issue Mar 21, 2024 · 0 comments · Fixed by #2716
Closed

<pf-button>: keyboard accessibility using spacebar key #2715

nikkimk opened this issue Mar 21, 2024 · 0 comments · Fixed by #2716
Assignees
@nikkimk
Labels
accessibility Improve accessibility bug priority: high Severity level: 1

Comments

@nikkimk
Copy link
Collaborator

nikkimk commented Mar 21, 2024

Description of the issue

A native button can be activated using spacebar as well as the Enter key. When on keydown using spacebar key to activate a <pf-button>, the browser window scrolls.

Impacted component(s)

  • <pf-button>
  • any components using <pf-button> in their shadowDOM

Steps to reproduce

  1. Go to Button docs
  2. Press Tab to navigate to any button.
  3. Press spacebar.
  4. Browser window scrolls.

Expected behavior

Browser window should not scroll.
@nikkimk nikkimk added accessibility Improve accessibility priority: high Severity level: 1 bug labels Mar 21, 2024
@nikkimk nikkimk self-assigned this Mar 21, 2024
@nikkimk nikkimk linked a pull request Mar 21, 2024 that will close this issue
fix(button): prevent default behavior for spacebar #2716
Merged
@nikkimk nikkimk assigned hellogreg and unassigned hellogreg Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikkimk nikkimk

Labels
accessibility Improve accessibility bug priority: high Severity level: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): prevent default behavior for spacebar patternfly/patternfly-elements
2 participants
@hellogreg @nikkimk