Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): styles for slotted menu #2713

Merged
merged 4 commits into from
Mar 24, 2024
Merged

fix(dropdown): styles for slotted menu #2713

merged 4 commits into from
Mar 24, 2024

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Mar 21, 2024 •
edited
Loading

What I did

  1. apply dropdown menu styles to slotted menu

Testing Instructions

  1. try the versions dropdown on the dp https://deploy-preview-2713--patternfly-elements.netlify.app/components

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a5cbfe5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass labels Mar 21, 2024
@bennypowers bennypowers enabled auto-merge (squash) March 21, 2024 13:53
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 8c9030f
😎 Deploy Preview https://deploy-preview-2713--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 21, 2024
@bennypowers bennypowers requested review from zeroedin and nikkimk March 22, 2024 04:07
@bennypowers bennypowers mentioned this pull request Mar 22, 2024
Closed
@bennypowers bennypowers linked an issue Mar 22, 2024 that may be closed by this pull request
The versions dropdown is not opening correctly in the documentation site #2717
Closed
@bennypowers bennypowers disabled auto-merge March 24, 2024 09:48
@bennypowers bennypowers merged commit 1b8f5ae into main Mar 24, 2024
8 checks passed
@bennypowers bennypowers deleted the fix/dropdown/slotted-styles branch March 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroedin zeroedin Awaiting requested review from zeroedin

@nikkimk nikkimk Awaiting requested review from nikkimk

Assignees
No one assigned
Labels
AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass
Projects
Workflow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The versions dropdown is not opening correctly in the documentation site
1 participant
@bennypowers