Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-area): autoresize #2720

Merged
merged 5 commits into from
Mar 27, 2024
Merged

fix(text-area): autoresize #2720

merged 5 commits into from
Mar 27, 2024

Conversation

bennypowers
Copy link
Member

Closes #2718

What I did

  1. implement auto-resize

Testing Instructions

  1. load up the demo /components/text-area/demo/auto-resizing/
  2. add some lines of text
  3. see that the textarea resizes

@bennypowers bennypowers requested a review from zeroedin March 24, 2024 11:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9789f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers enabled auto-merge (squash) March 24, 2024 11:29
@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Mar 24, 2024
@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 71aa62a
😎 Deploy Preview https://deploy-preview-2720--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 9789f99
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/66043dd63809c50008f15de5
😎 Deploy Preview https://deploy-preview-2720--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bennypowers bennypowers merged commit 02d7e71 into main Mar 27, 2024
14 checks passed
@bennypowers bennypowers deleted the fix/text-area/auto-resize branch March 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroedin zeroedin zeroedin approved these changes

Assignees
No one assigned
Labels
AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready to merge
Projects
Workflow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pf-text-area : Auto Resizing Text Area is not working as expected.
2 participants
@bennypowers @zeroedin