Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(jump-links): fix scrollspy demo layout #2721

Merged
merged 3 commits into from
Mar 28, 2024
Merged

docs(jump-links): fix scrollspy demo layout #2721

merged 3 commits into from
Mar 28, 2024

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Mar 24, 2024 •
edited by zeroedin
Loading

What I did

  1. adjust the demo page css to fix the horizontal jump links layout

Testing instructions

Closes #2719

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 38fcdd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the demo Updating demo pages label Mar 24, 2024
@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 6e8638b
😎 Deploy Preview https://deploy-preview-2721--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 38fcdd9
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/660586e31347f700085a8879
😎 Deploy Preview https://deploy-preview-2721--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeroedin zeroedin enabled auto-merge March 28, 2024 15:09
@zeroedin zeroedin merged commit ef2ed60 into main Mar 28, 2024
22 checks passed
@zeroedin zeroedin deleted the docs/jump-links/fix-demo branch March 28, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroedin zeroedin zeroedin approved these changes

Assignees
No one assigned
Labels
AT passed Automated testing has passed demo Updating demo pages ready to merge
Projects
Workflow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pf-jump-links : "Scrollspy with subsections" isn't working as expected.
2 participants
@bennypowers @zeroedin