Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing ariaDescription to InternalsController #2727

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

zeroedin
Copy link
Collaborator

What I did

  1. Added ariaDescription to InternalsController

Closes #2726

Testing Instructions

Notes to Reviewers

@zeroedin zeroedin requested a review from bennypowers March 26, 2024 16:50
@zeroedin zeroedin self-assigned this Mar 26, 2024
Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 73d720d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zeroedin zeroedin changed the title Fix/internals/aria mixin description fix(core): add missing ariaDescription to InternalsController Mar 26, 2024
Copy link
Contributor

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 2a3b3c2
😎 Deploy Preview https://deploy-preview-2727--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 73d720d
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/6602fcbb03ab5a0008ba6e55
😎 Deploy Preview https://deploy-preview-2727--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bennypowers bennypowers merged commit e62244f into main Mar 27, 2024
20 checks passed
@bennypowers bennypowers deleted the fix/internals/aria-mixin-description branch March 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed ready to merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] ariaDescription missing from InternalsController
2 participants