Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pf-icon v2 icons not displaying #2792

Closed
rlahoda opened this issue Jun 25, 2024 · 1 comment · Fixed by #2793
Closed

pf-icon v2 icons not displaying #2792

rlahoda opened this issue Jun 25, 2024 · 1 comment · Fixed by #2793
Labels
bug priority: high Severity level: 1

Comments

@rlahoda
Copy link
Contributor

rlahoda commented Jun 25, 2024

Description of the issue

When using pf-icon v2 the icons are not displaying. Checking the console there are these errors for each icon:

[pf-icon] The specifier “@patternfly/icons/fas/cloud.js” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”.

PFE v2.2.2 is imported by Primer so this is impacting any sites currently using pf-icon on the portal.

Impacted component(s)

  • pf-icon

Steps to reproduce

  1. Go to https://patternflyelements.org/v2/components/icon/
  2. Check console
  3. See error

Expected behavior

The icon component should display icons.

Screenshots

image

Related issues

@rlahoda rlahoda added priority: high Severity level: 1 bug labels Jun 25, 2024
@bennypowers
Copy link
Member

For the portal, you can set an import map, or use PfIcon.getIconUrl to point to a url that's more convenient

Keep in mind that this will change in version 4, see #2766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority: high Severity level: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants