Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix v2 pficon getIconUrl override #2793

Merged
merged 1 commit into from
Jun 25, 2024
Merged

docs: fix v2 pficon getIconUrl override #2793

merged 1 commit into from
Jun 25, 2024

Conversation

zeroedin
Copy link
Collaborator

What I did

  1. Fix missing override for /v2 path pf-icons

Closes #2792

Testing Instructions

Notes to Reviewers

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: abb6e65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zeroedin zeroedin self-assigned this Jun 25, 2024
@zeroedin zeroedin added the bug label Jun 25, 2024
@github-actions github-actions bot added the doc label Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 5dcb80d
😎 Deploy Preview https://deploy-preview-2793--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jun 25, 2024
@zeroedin zeroedin merged commit 23b0685 into main Jun 25, 2024
25 checks passed
@zeroedin zeroedin deleted the docs/v2-icons-path branch June 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennypowers bennypowers bennypowers approved these changes

Assignees

@zeroedin zeroedin

Labels
AT passed Automated testing has passed bug doc ready to merge
Projects
Workflow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pf-icon v2 icons not displaying
2 participants
@zeroedin @bennypowers