Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - fix code example of customized title on typography page #4376

Closed
mcoker opened this issue Nov 14, 2024 · 0 comments · Fixed by #4420
Closed

Bug - fix code example of customized title on typography page #4376

mcoker opened this issue Nov 14, 2024 · 0 comments · Fixed by #4420
Assignees
Labels
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Nov 14, 2024

The code below looks like a bug? Both blocks are the same code

<Title headingLevel="h2"> This is a default "xl" H2. </Title>
```<Title headingLevel="h2" size='lg'> Aa </Title>```
<Title headingLevel="h2" size='lg'> This is a customized "lg" H2. </Title>
```<Title headingLevel="h2" size='lg'> Aa </Title>```

I'm assuming the first block should just omit the size prop and use the default, like <Title headingLevel="h2"> Aa </Title>

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 14, 2024
@edonehoo edonehoo moved this from Needs triage to Backlog in PatternFly Issues Nov 19, 2024
@edonehoo edonehoo added this to the 2025.Q1 milestone Nov 19, 2024
@edonehoo edonehoo self-assigned this Dec 17, 2024
@edonehoo edonehoo moved this from Backlog to Not started in PatternFly Issues Dec 17, 2024
@edonehoo edonehoo moved this from Not started to In Progress in PatternFly Issues Dec 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants