Skip to content

Commit b6bbfc2

Browse files
authored
chore(Table): fix editable table alignment (#12619)
1 parent 1fe30b1 commit b6bbfc2

1 file changed

Lines changed: 34 additions & 36 deletions

File tree

packages/react-table/src/components/Table/examples/TableEditable.tsx

Lines changed: 34 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -35,49 +35,47 @@ const EditButtonsCell: React.FunctionComponent<EditButtonsCellProps> = ({
3535

3636
return (
3737
<>
38-
<Td
39-
dataLabel="Save and cancel buttons"
40-
className={css(
41-
inlineEditStyles.inlineEditGroup,
42-
inlineEditStyles.modifiers.iconGroup,
43-
inlineEditStyles.modifiers.actionGroup
44-
)}
45-
>
46-
<div className={css(inlineEditStyles.inlineEditAction, inlineEditStyles.modifiers.valid)}>
47-
<Button
48-
aria-label={`Save edits of ${rowAriaLabel}`}
49-
onClick={() => onClick('save')}
50-
onKeyDown={(event) => onKeyDown(event, 'stopEditing')}
51-
variant="plain"
52-
>
53-
<RhMicronsCheckmarkIcon />
54-
</Button>
38+
<Td dataLabel="Edit row data" hasAction>
39+
<div
40+
className={css(
41+
inlineEditStyles.inlineEditGroup,
42+
inlineEditStyles.modifiers.iconGroup,
43+
inlineEditStyles.modifiers.actionGroup
44+
)}
45+
>
46+
<div className={css(inlineEditStyles.inlineEditAction, inlineEditStyles.modifiers.valid)}>
47+
<Button
48+
aria-label={`Save edits of ${rowAriaLabel}`}
49+
onClick={() => onClick('save')}
50+
onKeyDown={(event) => onKeyDown(event, 'stopEditing')}
51+
variant="plain"
52+
>
53+
<RhMicronsCheckmarkIcon />
54+
</Button>
55+
</div>
56+
<div className={css(inlineEditStyles.inlineEditAction)}>
57+
<Button
58+
aria-label={`Discard edits of ${rowAriaLabel}`}
59+
onClick={() => onClick('cancel')}
60+
onKeyDown={(event) => onKeyDown(event, 'stopEditing')}
61+
variant="plain"
62+
>
63+
<RhMicronsCloseIcon />
64+
</Button>
65+
</div>
5566
</div>
56-
<div className={css(inlineEditStyles.inlineEditAction)}>
67+
<div className={css(inlineEditStyles.inlineEditAction, inlineEditStyles.modifiers.enableEditable)}>
5768
<Button
58-
aria-label={`Discard edits of ${rowAriaLabel}`}
59-
onClick={() => onClick('cancel')}
60-
onKeyDown={(event) => onKeyDown(event, 'stopEditing')}
69+
ref={editButtonRef}
70+
aria-label={`Edit ${rowAriaLabel}`}
71+
onClick={() => onClick('edit')}
72+
onKeyDown={(event) => onKeyDown(event, 'edit')}
6173
variant="plain"
6274
>
63-
<RhMicronsCloseIcon />
75+
<RhUiEditFillIcon />
6476
</Button>
6577
</div>
6678
</Td>
67-
<Td
68-
dataLabel="Edit button"
69-
className={css(inlineEditStyles.inlineEditAction, inlineEditStyles.modifiers.enableEditable)}
70-
>
71-
<Button
72-
ref={editButtonRef}
73-
aria-label={`Edit ${rowAriaLabel}`}
74-
onClick={() => onClick('edit')}
75-
onKeyDown={(event) => onKeyDown(event, 'edit')}
76-
variant="plain"
77-
>
78-
<RhUiEditFillIcon />
79-
</Button>
80-
</Td>
8179
</>
8280
);
8381
};

0 commit comments

Comments
 (0)