Skip to content

CodeBlock - aria attributes need updating in examples #11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thatblindgeye opened this issue Jan 8, 2025 · 3 comments · May be fixed by #11748
Open

CodeBlock - aria attributes need updating in examples #11386

thatblindgeye opened this issue Jan 8, 2025 · 3 comments · May be fixed by #11748
Labels
A11y PF Team

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Jan 8, 2025 •
edited
Loading

Describe the enhancement or change
For both examples, the aria-label of the buttons should be updated:

  • the copy button should have an aria-label that conveys what will be copied, e.g. Copy to clipboard basic example code block.
  • The "play" button aria-label shouldn't have the word "icon" in it and either just be "Play" or follow the ClipboardCopy additional actions example and use "Run in web terminal" -- this should also have a tooltip aplied to it.

For the expandable example, the aria-labelledby on the expandable content points to a non-existent ID. Passing the same toggleId to both ExpandableSection and ExpandableSectionToggle will resolve this.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 8, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to Backlog in PatternFly Issues Jan 16, 2025
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Mar 10, 2025
@Mash707
Copy link
Contributor

Mash707 commented Apr 6, 2025

@thatblindgeye some changes were made regarding this in #11583, could you check once. Thank You.

@thatblindgeye
Copy link
Contributor Author

@Mash707 yep that second bullet is no longer relevant here, thank you!

@Mash707 Mash707 linked a pull request Apr 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11y PF Team
Projects
PatternFly Issues
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(code block): update aria labels in examples Mash707/patternfly-react
2 participants
@thatblindgeye @Mash707