Allow the usage of stack-based strings #762
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToString::to_stringmakes a heap allocation and such a thing can cause a negative performance impact if used in a hot path. For example:One of the reasons why serialization was slow was also due to two heap allocations (#296). Therefore, it would be nice to expose
to_str_internal.The only pseudo-disadvantage is hard coding
arrayvecinto public interfaces but this can be mitigated in the future with a custom home-madeArrayStringthat returns([u8; MAX_STR_BUFFER_SIZE], u8).