Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a mechanism to deactivate PDI on demand #438

Open
jbigot opened this issue Sep 25, 2023 · 0 comments · May be fixed by #543
Open

Provide a mechanism to deactivate PDI on demand #438

jbigot opened this issue Sep 25, 2023 · 0 comments · May be fixed by #543
Assignees
@JAuriac
Labels
level:: newcomer_job An issue whose resolution is well suited for newcomers module:: c api request:: feature

Comments

@jbigot
Copy link
Member

jbigot commented Sep 25, 2023

In GitLab by @fxmordant on Sep 25, 2023, 15:54

In certain cases, users may want to temporarily deactivate PDI's functionality at runtime without modifying the existing code.
Currently, there is no straightforward way to achieve this.

To address this, a proposed solution is to include a separate header file (e.g. pdi_deactivation.h) that would redefine the PDI API with empty functions, disabling PDI's operation while maintaining valid syntax.
Users would only need to add this header file when they wish to temporarily deactivate PDI.
@jbigot jbigot added the level:: newcomer_job An issue whose resolution is well suited for newcomers label Oct 30, 2024
@JAuriac JAuriac self-assigned this Nov 28, 2024
JAuriac added a commit that referenced this issue Nov 28, 2024
@JAuriac
Refactor to remove redundancies between pdi.h and pdi_deactivation.h,…
1385e76 
… and prepare for PR, Fix #438
@JAuriac JAuriac mentioned this issue Nov 28, 2024
Closed
17 tasks
JAuriac added a commit that referenced this issue Dec 2, 2024
@JAuriac
Ready for PR, Fix #438, include unit test for PDI C deactivation, to …
4e7c3b7 
…do : Fortran equivalent
JAuriac added a commit that referenced this issue Dec 2, 2024
@JAuriac
Ready for PR, Fix #438, Fix indent issue on test file 06
cc1a02b
JAuriac added a commit that referenced this issue Dec 2, 2024
@JAuriac
Ready for PR, Fix #438, Fix indent issue on test file 06 n°2
eec80b6
JAuriac added a commit that referenced this issue Dec 2, 2024
@JAuriac
Ready for PR, Fix #438, Fix indent issue on test file 06 n°3
9c7ef92
JAuriac added a commit that referenced this issue Dec 2, 2024
@JAuriac
Ready for PR, Fix #438, Fix indent issue on test file 06 n°4 and add …
6091396 
…deactivation mention to pull_request_template.md
JAuriac added a commit that referenced this issue Jan 30, 2025
@JAuriac
Fix #438, cleaning and refactoring, folowwing pull request template
43aaa5d
JAuriac added a commit that referenced this issue Jan 30, 2025
@JAuriac
Fix #438, cleaning and refactoring, following pull request template
d209965
JAuriac added a commit that referenced this issue Jan 30, 2025
@JAuriac
Fix #438, cleaning
825cc8a
JAuriac added a commit that referenced this issue Feb 7, 2025
@JAuriac
Fix #438, Fix indent
8bb9a02
JAuriac added a commit that referenced this issue Feb 7, 2025
@JAuriac
Fix #438, Fix indent 2
110d045
@JAuriac JAuriac linked a pull request Feb 7, 2025 that will close this issue
Fix #438, add PDI deactivation option through CMake #527
Closed
17 tasks
JAuriac added a commit that referenced this issue Feb 7, 2025
@JAuriac
Fix #438, Fix indent 3
fb8014a
JAuriac added a commit that referenced this issue Feb 7, 2025
@JAuriac
Fix #438, Fix indent 4
90e8f43
JAuriac added a commit that referenced this issue Feb 7, 2025
@JAuriac
Fix #438, Fix indent 5
fc2ad4c
JAuriac added a commit that referenced this issue Feb 7, 2025
@JAuriac
Fix #438, Fix indent 6
050082d
@JAuriac JAuriac removed a link to a pull request Feb 20, 2025
Fix #438, add PDI deactivation option through CMake #527
Closed
17 tasks
@JAuriac JAuriac linked a pull request Feb 20, 2025 that will close this issue
Fix #438, add three PDI deactivation option through CMake #543
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JAuriac JAuriac

Labels
level:: newcomer_job An issue whose resolution is well suited for newcomers module:: c api request:: feature
Projects
None yet
Milestone
No milestone
2 participants
@jbigot @JAuriac