Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative margin-top/left is not being applied properly #271

Open
miguelleite opened this issue Jul 24, 2015 · 0 comments
Open

Negative margin-top/left is not being applied properly #271

miguelleite opened this issue Jul 24, 2015 · 0 comments

Comments

@miguelleite
Copy link

Hey there,
I just found that neither the negative margin-top (in the 'vertical' direction) nor the negative margin-left (in the 'horizontal' direction) are being applied because the $('ul.onepage-pagination') doesn't belong to the 'el' object.

Suggestion to solve this issue:

https://github.com/peachananr/onepage-scroll/blob/master/jquery.onepage-scroll.js#L331 should be placed before the line 324.
• replace 'el.find(".onepage-pagination")' on both lines L326 and L329 with '$(".onepage-pagination")'.

Great work with the plugin, thanks for that and congratulations!
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant