0.8.20 - an update comes back as the same copy it was (#34)

Found by running a real 0.8.18 and watching it update to 0.8.19.

Author: peans99

Directory.Build.props

@@ -10,9 +10,9 @@
     <Copyright>Copyright © nekron</Copyright>
     <Description>A pilot's logbook for Star Citizen: second-screen dashboard, in-game overlay, and flight-log analysis for Star Citizen, driven by Game.log.</Description>
 
-    <Version>0.8.19</Version>
-    <AssemblyVersion>0.8.19.0</AssemblyVersion>
-    <FileVersion>0.8.19.0</FileVersion>
+    <Version>0.8.20</Version>
+    <AssemblyVersion>0.8.20.0</AssemblyVersion>
+    <FileVersion>0.8.20.0</FileVersion>
 
     <RepositoryUrl>https://github.com/peans99/QuantumWake</RepositoryUrl>
     <PackageProjectUrl>https://github.com/peans99/QuantumWake</PackageProjectUrl>

README.md

@@ -353,6 +353,13 @@ affiliated with or endorsed by Cloud Imperium Games.
 Newest first. Each version's section is what the GitHub release says too — the
 release workflow lifts it from here, so it is written once.
 
+### 0.8.20
+
+- **An update keeps the settings it was started with.** Restarting after an
+  update dropped any `--data`, `--path` or `-Lan` given on the command line,
+  so a copy deliberately pointed at its own folder came back pointed at the
+  default one. It now comes back as the same copy it was.
+
 ### 0.8.19
 
 - **The update button says what the download costs.** Ninety megabytes is

src/Quantumwake.Overlay/App.xaml.cs

@@ -30,6 +30,7 @@ public partial class App : System.Windows.Application
     private const string DashboardUrl = "http://127.0.0.1:31337/";
 
     private WebApplication? _server;
+    private string[] _arguments = [];
     private TrayPresence? _tray;
     private MainWindow? _overlay;
     private Settings _settings = new();
@@ -45,6 +46,10 @@ protected override async void OnStartup(StartupEventArgs e)
 
         // Before Settings.Load, so --data moves the whole app - overlay
         // preferences and WebView2 profile included - and not just the server.
+        // Kept for Restart: an update replaces the file and starts it again,
+        // and it has to come back as the same copy rather than the default one.
+        _arguments = e.Args;
+
         Core.AppPaths.UseFromArguments(e.Args);
 
         _settings = Settings.Load();
@@ -170,11 +175,29 @@ private void PickInstallFolder()
             Restart();
     }
 
+    /// <summary>
+    /// Starts this application again and stands down.
+    /// </summary>
+    /// <remarks>
+    /// The arguments come too. Dropping them looks harmless because most people
+    /// pass none, but --data moves every store and --path names the install, so
+    /// a restart without them silently points a second copy at the default
+    /// folder - somebody else's real data, if this one was deliberately kept
+    /// away from it. Found by updating a copy running on --data and watching the
+    /// new process come back with none.
+    /// </remarks>
     private void Restart()
     {
         var exe = Environment.ProcessPath;
+
         if (exe is not null)
-            Process.Start(new ProcessStartInfo(exe) { UseShellExecute = true });
+        {
+            var start = new ProcessStartInfo(exe) { UseShellExecute = true };
+            foreach (var argument in _arguments)
+                start.ArgumentList.Add(argument);
+
+            Process.Start(start);
+        }
 
         Quit();
     }