Merge pull request #407 from peopledoc/FORM-1616-fix-default-readonly-dict

Fix defaults on readonly during validation from schema

Author: Sylvain Delabye

CHANGELOG.rst

@@ -5,6 +5,7 @@ ChangeLog
 master (unreleased)
 ===================
 
+- Fix defaults on readonly fields during validation from schema
 - Fix default values for readonly date fields.
 - Improve default values for readonly fields.
 - Applying isort v5+ changes: no ``--recursive flag``, removed the ``not_skip`` settings. (internal change, no runtime impact).

demo/tests/test_integration.py

@@ -430,6 +430,33 @@ def test_form_readonly_empty_defaults(self):
             'readonly_radios_buttons': 'val1'
         })
 
+    def test_validate_form_readonly_empty_defaults(self):
+
+        session = self.client.session
+        session['role'] = 'padawan'
+        session.save()
+
+        form_data = deepcopy(form_data_readonly)
+        # Preparing a "bad" defaults
+        for field in form_data['fields']:
+            field['defaults'].append("")  # empty value
+
+        res = self.client.post(
+            reverse('formidable:form_create'),
+            form_data, format='json')
+        self.assertEquals(res.status_code, 201)
+        formidable = Formidable.objects.order_by('pk').last()
+
+        # Validation from schema
+        res = self.client.post(
+            reverse('form_validation_schema', args=[formidable.pk]),
+            {}, format='json'
+        )
+        self.assertEqual(res.status_code, 204)
+        self.assertIn(res.content, ("", b""))  # Should be empty
+        # As a consequence, if there's no body content, there shouldn't be any
+        # content-type sent back to the client.
+
 
 class TestChain(FormidableAPITestCase):
 

formidable/forms/field_builder.py

@@ -96,7 +96,7 @@ def get_disabled(self):
 
     def get_initial(self):
         if self.field_is_dict and 'defaults' in self.field:
-            defaults = self.field['defaults']
+            defaults = [x for x in self.field['defaults'] if x]
             if len(defaults) > 0:
                 if (self.field_class == MultipleChoiceField
                         or self.field.get('multiple', False)):