Skip to content

Commit 17efb62

Browse files
authored
Merge pull request #273 from novafloss/272-drf-3.7-incompatible-with-django-1.8
Reflect incompatibility between Django 1.8 and DRF 3.7 by changing requirements in tox tests
2 parents db62af0 + 396812c commit 17efb62

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ ChangeLog
55
master (unreleased)
66
===================
77

8-
Nothing here yet.
8+
- As of its 3.7 version, it appears that Django REST Framework is no longer compatible with Django 1.8. Added a mention in the README, in the deprecation timeline, and changed tox requirements to reflect this (#272).
99

1010
Release 1.0.1 (2017-10-04)
1111
==========================

README.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ Warnings
1818

1919
See the `Deprecation timeline <http://django-formidable.readthedocs.io/en/latest/deprecations.html>`_ document for more information on deprecated versions.
2020

21+
.. warning::
22+
23+
As of its 3.7 version, it appears that Django REST Framework only supports Django 1.10 & 1.11. Carefully freeze your dependencies if your Django version is not compatible.
24+
2125
License
2226
=======
2327

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ changedir = demo
1414
deps =
1515
; Django versions
1616
django18: Django>=1.8,<1.9
17+
django18: djangorestframework<3.7
1718
django19: Django>=1.9,<1.10
1819
django110: Django>=1.10,<1.11
1920
; Requirements from demo project

0 commit comments

Comments
 (0)