Check for unicity in NestedListSerializers

Author: Mickaël Guérin

formidable/serializers/access.py

@@ -36,6 +36,7 @@ class AccessListSerializer(NestedListSerializer):
     parent_name = 'field_id'
 
     def validate(self, data):
+        data = super(AccessListSerializer, self).validate(data)
         accesses_id = [accesses['access_id'] for accesses in data]
 
         for access in get_accesses():

formidable/serializers/fields.py

@@ -41,6 +41,8 @@ def validate(self, validated_data):
         order before the update/create method sorts the validated data
         by id.
         """
+        validated_data = super(FieldListSerializer, self).validate(
+                validated_data)
         for index, data in enumerate(validated_data):
             data['order'] = index
 

formidable/serializers/list.py

@@ -4,6 +4,7 @@
 
 import logging
 
+from rest_framework.exceptions import ValidationError
 from rest_framework.serializers import ListSerializer
 
 logger = logging.getLogger(__name__)
@@ -50,6 +51,21 @@ def _extract_id(self, qs, validated_data):
         deleted_ids = db_ids - validated_ids
         return created_ids, updated_ids, deleted_ids
 
+    def validate(self, data):
+        """
+        ensure that field_id is unique among children
+        """
+        data = super(NestedListSerializer, self).validate(data)
+
+        if self.field_id:
+            if len(data) != len(set(f[self.field_id] for f in data)):
+                msg = 'The fields {field_id} must make a unique set.'.format(
+                        field_id=self.field_id
+                )
+                raise ValidationError(msg, code='unique')
+
+        return data
+
 
 class NestedListSerializerDummyUpdate(NestedListSerializer):