Skip to content

Commit dbb8e64

Browse files
moumouttebrunobord
authored andcommitted
refs #157, Remove a useless Prefetch on retrieve view
1 parent 7b1da52 commit dbb8e64

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

demo/tests/perfs/tests_integration.perf.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ TestContextFormEndPoint.test_queryset:
88
- db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...)
99
UpdateFormTestCase.test_queryset_on_get:
1010
- db: 'SELECT ... FROM "formidable_formidable" WHERE "formidable_formidable"."id" = #'
11-
- db: SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" IN (#) ORDER BY "formidable_field"."order" ASC
1211
- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
1312
- db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC
1413
- db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...)

formidable/views.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from django.conf import settings
77
from django.core.exceptions import ImproperlyConfigured
8-
from django.db.models import Prefetch
98

109
import six
1110
from rest_framework import exceptions
@@ -21,7 +20,7 @@
2120
FileFieldBuilder, FormFieldFactory, SkipField
2221
)
2322
from formidable.forms.validations.presets import presets_register
24-
from formidable.models import Field, Formidable
23+
from formidable.models import Formidable
2524
from formidable.serializers import FormidableSerializer, SimpleAccessSerializer
2625
from formidable.serializers.forms import ContextFormSerializer
2726
from formidable.serializers.presets import PresetsSerializer
@@ -176,11 +175,6 @@ class FormidableDetail(six.with_metaclass(MetaClassView,
176175
success_callback_settings = 'FORMIDABLE_POST_UPDATE_CALLBACK_SUCCESS'
177176
failure_callback_settings = 'FORMIDABLE_POST_UPDATE_CALLBACK_FAIL'
178177

179-
def get_queryset(self):
180-
qs = super(FormidableDetail, self).get_queryset()
181-
field_qs = Field.objects.order_by('order')
182-
return qs.prefetch_related(Prefetch('fields', queryset=field_qs))
183-
184178

185179
class FormidableCreate(six.with_metaclass(MetaClassView,
186180
CallbackMixin, CreateAPIView)):

0 commit comments

Comments
 (0)