PMM-14442 Fix the data race

ademidoff · ademidoff · commit 8f09cce19663 · 2025-11-27T17:49:13.000+03:00
diff --git a/managed/services/ha/services.go b/managed/services/ha/services.go
@@ -68,14 +68,14 @@ func (s *services) StartAllServices(ctx context.Context) {
 		if _, ok := s.running[id]; !ok {
 			s.wg.Add(1)
 			s.running[id] = service
-			go func() {
-				s.l.Infoln("Starting", service.ID())
-				err := service.Start(ctx)
+			go func(svc LeaderService, svcID string) {
+				s.l.Infoln("Starting", svcID)
+				err := svc.Start(ctx)
 				if err != nil {
 					s.l.Errorln(err)
-					s.removeService(service.ID())
+					s.removeService(svcID)
 				}
-			}()
+			}(service, id)
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -68,14 +68,14 @@ func (s *services) StartAllServices(ctx context.Context) {`
`68`	`68`	`if _, ok := s.running[id]; !ok {`
`69`	`69`	`s.wg.Add(1)`
`70`	`70`	`s.running[id] = service`
`71`		`- go func() {`
`72`		`- s.l.Infoln("Starting", service.ID())`
`73`		`- err := service.Start(ctx)`
	`71`	`+ go func(svc LeaderService, svcID string) {`
	`72`	`+ s.l.Infoln("Starting", svcID)`
	`73`	`+ err := svc.Start(ctx)`
`74`	`74`	`if err != nil {`
`75`	`75`	`s.l.Errorln(err)`
`76`		`- s.removeService(service.ID())`
	`76`	`+ s.removeService(svcID)`
`77`	`77`	`}`
`78`		`- }()`
	`78`	`+ }(service, id)`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`	`}`