libpcp: macOS getaddrinfo requires extra non-failure check

natoscott · natoscott · commit 59d4fd95179f · 2025-11-03T10:02:51.000+11:00
diff --git a/src/libpcp/src/access.c b/src/libpcp/src/access.c
@@ -861,7 +861,7 @@ getHostAccessSpecs(const char *name, int *sts)
 	}
 	__pmHostEntFree(servInfo);
     }
-    else {
+    else if (hosterror()) {
 	char	errmsg[PM_MAXERRMSGLEN];
 	PM_LOCK(__pmLock_extcall);
 	pmstrncpy(errmsg, PM_MAXERRMSGLEN, hoststrerror());	/* THREADSAFE */

Original file line number	Diff line number	Diff line change
`@@ -861,7 +861,7 @@ getHostAccessSpecs(const char name, int sts)`
`861`	`861`	`}`
`862`	`862`	`__pmHostEntFree(servInfo);`
`863`	`863`	`}`
`864`		`- else {`
	`864`	`+ else if (hosterror()) {`
`865`	`865`	`char errmsg[PM_MAXERRMSGLEN];`
`866`	`866`	`PM_LOCK(__pmLock_extcall);`
`867`	`867`	`pmstrncpy(errmsg, PM_MAXERRMSGLEN, hoststrerror()); /* THREADSAFE */`