Skip to content

Commit 5845db5

Browse files
committed
Stricter release plan: more checks
Checked dist DBI-1.647.tgz Kwalitee rating 157.89% (30/19)
1 parent f0f9b38 commit 5845db5

10 files changed

+24
-18
lines changed

DBI.pm

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use warnings;
1616

1717
our ($XS_VERSION, $VERSION);
1818
BEGIN {
19-
$VERSION = "1.646"; # ==> ALSO update the version in the pod text below!
19+
$VERSION = "1.647"; # ==> ALSO update the version in the pod text below!
2020
$XS_VERSION = $VERSION;
2121
$VERSION =~ tr/_//d;
2222
}
@@ -148,7 +148,7 @@ sure that your issue isn't related to the driver you're using.
148148
149149
=head2 NOTES
150150
151-
This is the DBI specification that corresponds to DBI version 1.646
151+
This is the DBI specification that corresponds to DBI version 1.647
152152
(see L<DBI::Changes> for details).
153153
154154
The DBI is evolving at a steady pace, so it's good to check that

Makefile.PL

+13-7
Original file line numberDiff line numberDiff line change
@@ -381,19 +381,25 @@ checkkeywords:
381381
find . -type f \( -name .svn -prune -o -name \*.pm -o -name \*.PL -o -name \*.pl \) \
382382
-exec bash -c '[ -z "$$(svn pg svn:keywords {})" ] && echo svn propset svn:keywords \"Id Revision\" {}' \;
383383
384-
.PHONY: doc change changes spellcheck checkpod
384+
.PHONY: doc change changes spellcheck checkpod newdist
385385
changes: $(changes_pm1)
386386
doc:
387387
perl doc/make-doc.pl --pod
388+
spellcheck checkpod: doc
389+
pod-spell-check -i -a doc/*.pod
390+
388391
dbipport:
389392
perl sandbox/genPPPort_h.pl
390393
ppport: dbipport.h
391-
perl dbipport.h --compat-version=5.8.0 DBI.xs
392-
393-
tgzdist: changes doc dist
394-
395-
spellcheck checkpod: doc
396-
pod-spell-check -i -a doc/*.pod
394+
perl dbipport.h --compat-version=5.8.1 DBI.xs
395+
396+
# make dist does not remove existing .tar.gz causing questions
397+
newdist:
398+
-@rm -f $(DISTVNAME).tar.gz $(DISTVNAME).tgz
399+
tgzdist: changes spellcheck newdist dist
400+
-@mv -f $(DISTVNAME).tar.gz $(DISTVNAME).tgz
401+
-@cpants_lint.pl $(DISTVNAME).tgz
402+
-@rm -f Debian_CPANTS.txt
397403
};
398404

399405
return $xst;

doc/DBD-Gofer-Transport-Base.3

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ Returns true (would like to retry), false (must not retry), undef (no preference
150150
.PP
151151
If a true value is returned in the form of a CODE ref then, if DBD::Gofer does
152152
decide to retry the request, it calls the code ref passing \f(CW$retry_count\fR, \f(CW$retry_limit\fR.
153-
Can be used for logging and/or to implement exponential backoff behaviour.
153+
Can be used for logging and/or to implement exponential back\-off behaviour.
154154
Currently the called code must return using \f(CW\*(C`return;\*(C'\fR to allow for future extensions.
155155
.SH AUTHOR
156156
.IX Header "AUTHOR"

doc/DBD-Gofer-Transport-Base.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ <h2 id="response_retry_preference">response_retry_preference</h2>
114114

115115
<p>Returns true (would like to retry), false (must not retry), undef (no preference).</p>
116116

117-
<p>If a true value is returned in the form of a CODE ref then, if DBD::Gofer does decide to retry the request, it calls the code ref passing $retry_count, $retry_limit. Can be used for logging and/or to implement exponential backoff behaviour. Currently the called code must return using <code>return;</code> to allow for future extensions.</p>
117+
<p>If a true value is returned in the form of a CODE ref then, if DBD::Gofer does decide to retry the request, it calls the code ref passing $retry_count, $retry_limit. Can be used for logging and/or to implement exponential back-off behaviour. Currently the called code must return using <code>return;</code> to allow for future extensions.</p>
118118

119119
<h1 id="AUTHOR">AUTHOR</h1>
120120

doc/DBD-Gofer-Transport-Base.man

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ METHODS
8989
If a true value is returned in the form of a CODE ref then, if
9090
DBD::Gofer does decide to retry the request, it calls the code ref
9191
passing $retry_count, $retry_limit. Can be used for logging and/or to
92-
implement exponential backoff behaviour. Currently the called code
92+
implement exponential back-off behaviour. Currently the called code
9393
must return using "return;" to allow for future extensions.
9494

9595
AUTHOR

doc/DBD-Gofer-Transport-Base.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ Returns true (would like to retry), false (must not retry), undef (no preference
8989

9090
If a true value is returned in the form of a CODE ref then, if DBD::Gofer does
9191
decide to retry the request, it calls the code ref passing $retry\_count, $retry\_limit.
92-
Can be used for logging and/or to implement exponential backoff behaviour.
92+
Can be used for logging and/or to implement exponential back-off behaviour.
9393
Currently the called code must return using `return;` to allow for future extensions.
9494

9595
# AUTHOR

doc/DBD-Multiplex.3

+1-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ any errors, and returning all of the results.
186186
\&\fBlast_result_most_common\fR
187187
.Sp
188188
Execute the requested method against each child handle, not stopping after
189-
the errors, and returning the most common result (eg three\-way\-voting etc).
189+
the errors, and returning the most common result (e.g. three\-way\-voting etc).
190190
Not yet implemented.
191191
.IP \fBmx_shuffle\fR 4
192192
.IX Item "mx_shuffle"

doc/DBD-Multiplex.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ <h1 id="SPECIFIC-ATTRIBUTES">SPECIFIC ATTRIBUTES</h1>
139139

140140
<p><b>last_result_most_common</b></p>
141141

142-
<p>Execute the requested method against each child handle, not stopping after the errors, and returning the most common result (eg three-way-voting etc). Not yet implemented.</p>
142+
<p>Execute the requested method against each child handle, not stopping after the errors, and returning the most common result (e.g. three-way-voting etc). Not yet implemented.</p>
143143

144144
</dd>
145145
<dt id="mx_shuffle"><b>mx_shuffle</b></dt>

doc/DBD-Multiplex.man

+2-2
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ SPECIFIC ATTRIBUTES
123123
last_result_most_common
124124

125125
Execute the requested method against each child handle, not
126-
stopping after the errors, and returning the most common result (eg
127-
three-way-voting etc). Not yet implemented.
126+
stopping after the errors, and returning the most common result
127+
(e.g. three-way-voting etc). Not yet implemented.
128128

129129
mx_shuffle
130130
Shuffles the list of child handles each time it's about to be used.

doc/DBD-Multiplex.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ The following specific attributes can be set when connecting:
129129
**last\_result\_most\_common**
130130

131131
Execute the requested method against each child handle, not stopping after
132-
the errors, and returning the most common result (eg three-way-voting etc).
132+
the errors, and returning the most common result (e.g. three-way-voting etc).
133133
Not yet implemented.
134134

135135
- **mx\_shuffle**

0 commit comments

Comments
 (0)