Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser derive macro triggers forbidden-lint-groups lint #539

Open
Byter09 opened this issue Sep 14, 2021 · 0 comments
Open

Parser derive macro triggers forbidden-lint-groups lint #539

Byter09 opened this issue Sep 14, 2021 · 0 comments

Comments

@Byter09
Copy link

Byter09 commented Sep 14, 2021

Hello,

in the process of upgrading our CI to use the latest Rust toolchain (1.55.0), we've encountered an error originating from this crate.

It seems that the lint forbidden-lint-groups has been updated with this release, and thus does not allow clippy::all anymore.

As a hotfix, we've added #![allow(forbidden_lint_groups)] to the beginning of the file, as we can't apply it to the derive.

Given, that this is a hard error in the future, we're hoping that this issue will notify you of this upcoming change and speed up resolving this problem.

Here's the error:

error: allow(clippy::all) incompatible with previous forbid
   --> <censored>/src/gherkin.rs:304:10
    |
304 | #[derive(Parser)]
    |          ^^^^^^ overruled by previous forbid
    |
    = note: `-D forbidden-lint-groups` implied by `-D future-incompatible`
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #81670 <https://github.com/rust-lang/rust/issues/81670>
    = note: `forbid` lint level was set on command line
    = note: this error originates in the derive macro `Parser` (in Nightly builds, run with -Z macro-backtrace for more info)

And the related code:

#[derive(Parser)]
#[grammar = "gherkin.pest"]
struct GherkinParser;

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants