Skip to content

Commit bae1c39

Browse files
author
Ben Brown
committed
Adjust app_secret details
1 parent ceaf8eb commit bae1c39

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

changelog.md

+3
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ Add `controller.handleWebhookPayload()` to process a raw webhook payload and ing
1212

1313
Make stale connection detection configurable [PR #505](https://github.com/howdyai/botkit/pull/505)
1414

15+
DDOS Vulnerability Fix - Secure Facebook Webhook [PR #555](https://github.com/howdyai/botkit/pull/555)
16+
17+
1518
Bug fixes:
1619

1720
Fix an issue where a custom redirect_uri would be rejected by Slack's oauth verification

facebook_bot.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ This bot demonstrates many of the core features of Botkit:
2525
2626
Run your bot from the command line:
2727
28-
page_token=<MY PAGE TOKEN> verify_token=<MY_VERIFY_TOKEN> node facebook_bot.js [--lt [--ltsubdomain LOCALTUNNEL_SUBDOMAIN]]
28+
app_secret=<MY APP SECRET> page_token=<MY PAGE TOKEN> verify_token=<MY_VERIFY_TOKEN> node facebook_bot.js [--lt [--ltsubdomain LOCALTUNNEL_SUBDOMAIN]]
2929
3030
Use the --lt option to make your bot available on the web through localtunnel.me.
3131
@@ -104,7 +104,7 @@ var controller = Botkit.facebookbot({
104104
log: true,
105105
access_token: process.env.page_token,
106106
verify_token: process.env.verify_token,
107-
app_secret: process.env.app_secret
107+
app_secret: process.env.app_secret,
108108
validate_requests: true, // Refuse any requests that don't come from FB on your receive webhook, must provide FB_APP_SECRET in environment variables
109109
});
110110

lib/Facebook.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ function Facebookbot(configuration) {
496496
if (expected !== calculated) {
497497
throw new Error("Invalid signature on incoming request");
498498
} else {
499-
facebook_botkit.debug('** X-Hub Verification successful!')
499+
// facebook_botkit.debug('** X-Hub Verification successful!')
500500
}
501501
}
502502

0 commit comments

Comments
 (0)