Take exec's flags in any order (PHANTOM-66)

`phantom vm exec -it <id> -- vi` is what a hand types, having typed
`docker exec -it` a thousand times — and it took -it as the VM id, ran the
non-interactive path, and answered "VM is not running: -it". The id being
positional is no reason to refuse a flag before it: the first argument that is
not a flag (or a flag's value) is the id, wherever it sits.

Verified through the real CLI under a pty (script -q /dev/null): vi draws,
takes keystrokes and writes its file, and an interactive zsh gives a prompt and
exits cleanly — both argument orders.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: wddwycc

phantom-cli/src/commands/vm.ts

@@ -293,17 +293,30 @@ export async function vmExec(...args: string[]) {
     process.exit(1);
   }
 
-  const vmId = args[0]!; // guaranteed present since dashDashIndex >= 1
+  // Flags may come before or after the id: `exec -it <id> -- …` is what a hand
+  // types, having typed `docker exec -it` a thousand times, and the id being
+  // positional is no reason to make that an error. The first thing that is not
+  // a flag (or a flag's value) is the id.
+  let vmId: string | undefined;
   let user: string | undefined;
   let interactive = false;
-  for (let i = 1; i < dashDashIndex; i++) {
-    if (args[i] === "--user" && i + 1 < dashDashIndex) {
-      user = args[i + 1];
-      i++;
-    } else if (["-it", "-ti", "-i", "-t", "--tty"].includes(args[i]!)) {
+  for (let i = 0; i < dashDashIndex; i++) {
+    const arg = args[i]!;
+    if (arg === "--user" && i + 1 < dashDashIndex) {
+      user = args[++i];
+    } else if (["-it", "-ti", "-i", "-t", "--tty"].includes(arg)) {
       interactive = true;
+    } else if (!arg.startsWith("-") && !vmId) {
+      vmId = arg;
     }
   }
+
+  if (!vmId) {
+    console.error("Error: a VM id is required");
+    console.error("");
+    usage("exec");
+    process.exit(1);
+  }
   const command = args.slice(dashDashIndex + 1).join(" ");
 
   if (!command) {

phantom-cli/src/tmp-vi.ts

@@ -0,0 +1,22 @@
+import { sendStreamingRequest } from "./lib/api";
+const vmId = process.argv[2]!;
+let bytes = 0, esc = 0, first = "";
+const { exitCode } = await sendStreamingRequest(
+  { method: "vm.execStream", params: { vmId, user: "admin", waitForAgent: true, tty: true, rows: 24, cols: 80, term: "xterm-256color", command: "vi /tmp/probe.txt" } },
+  (c) => {
+    if (!c.data) return;
+    const b = c.encoding === "base64" ? Buffer.from(c.data, "base64") : Buffer.from(c.data);
+    bytes += b.length;
+    esc += (b.toString("latin1").match(/\x1b/g) ?? []).length;
+    if (!first) first = JSON.stringify(b.toString("latin1").slice(0, 120));
+  },
+  { timeoutMs: 30_000, onOpen: (send) => {
+      const key = (s: string) => send({ type: "stdin", data: Buffer.from(s, "latin1").toString("base64") });
+      setTimeout(() => key("iHELLO"), 1500);
+      setTimeout(() => key("\x1b"), 2500);
+      setTimeout(() => key(":wq\n"), 3000);
+  } }
+);
+console.log("bytes:", bytes, "escape sequences:", esc);
+console.log("first output:", first);
+console.log("exitCode:", exitCode);