Build - fix(Session): prevent dangling pointers in DeleteAllSessions Remove database_ref_.Reset() calls during DeleteAllSessions() iteration. The issue: Reset() can trigger GC, which may finalize Session JS objects that are still in our iteration list, creating dangling pointers → SIGSEGV. Why this is safe: - Our iteration only uses pure C/C++ ops (no Napi calls that trigger GC) - When Sessions are later GC'd, Delete() returns early (session_ is nullptr) - Napi::ObjectReference destructor handles re... #248
build.yml
on: push
Matrix: prebuild-linux-glibc
prebuild-mac-x64
2m 7s
prebuild-mac-arm64
58s
prebuild-win-x64
2m 23s
prebuild-win-arm64
3m 42s
Matrix: prebuild-linux-musl
lint
37s
Matrix: test-ubuntu
Matrix: test-api-compatibility
Matrix: test-mac-win
Matrix: test-alpine
publish
0s
Annotations
1 error and 3 warnings
|
test-alpine (arm64, 24)
Process completed with exit code 1.
|
|
lint:
test/common/test-utils.mjs#L24
Found mkdirSync from package "node:fs" with non literal argument at index 0
|
|
lint:
src/enhance.ts#L111
Generic Object Injection Sink
|
|
lint:
scripts/sync-node-tests.ts#L199
Found non-literal argument to RegExp Constructor
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
prebuilds-linux-arm64-glibc
|
1.11 MB |
sha256:b897f818b6a189cc4135e7c2c6e9f4070186198fd49fcc473c4e61e980a9bf8d
|
|
|
prebuilds-linux-arm64-musl
|
1.29 MB |
sha256:ce83c55be8ace135a060655a0059b77b3f264bc83136b5633e8af61d2bccad18
|
|
|
prebuilds-linux-x64-glibc
|
1.15 MB |
sha256:3d5d4c9c1d7838d36bce54ff08c7712ba7d60b491f0b17d12a06f8a2e6427b63
|
|
|
prebuilds-linux-x64-musl
|
1.29 MB |
sha256:756a68047689263bd714f590d18a7fdc598db66fdbdc5c464c7ab112e95adc56
|
|
|
prebuilds-mac-arm64
|
1 MB |
sha256:e74473e09f39122276916ac69b6a768bd76239f72d6ce6eba171316b3e7754f2
|
|
|
prebuilds-mac-x64
|
1.07 MB |
sha256:e60af8fae5ad76bc38149a0c557d069e050baaff6efb5a4023852b995b236b29
|
|
|
prebuilds-win-arm64
|
983 KB |
sha256:b1a9de66eb812d18aa341e7e493a98389236d520f21aa19086feb4ca6cf8cf13
|
|
|
prebuilds-win-x64
|
1.09 MB |
sha256:ac329b116f6b9b68a099217a4f7792653a39539de55244297ebc759ebcb0e695
|
|
|
test-extension-linux-arm64-musl
|
4.43 KB |
sha256:3b64234b0d92103d3609e124f57620bec3b8d881a9172f447f995fa288159f59
|
|
|
test-extension-linux-x64-musl
|
3.15 KB |
sha256:77baf31a8e1311d0b64d0c28071cfc85a5dd5a647b01ca49e283e7d66b93769d
|
|