test: add unit test for hidden images to SeriesServiceImpl.findFullInfoById()

Fix #1385

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/SeriesServiceImpl.java

@@ -335,7 +335,6 @@ public SeriesDto findFullInfoById(
 
 		List<Integer> imageIds = imageService.findBySeriesId(seriesId, false);
 
-		// @todo #1356 SeriesServiceImpl.findFullInfoById(): add unit test for hidden images
 		List<Integer> hiddenImageIds = Collections.emptyList();
 		if (userCanSeeHiddenImages) {
 			hiddenImageIds = imageService.findBySeriesId(seriesId, true);

src/test/groovy/ru/mystamps/web/feature/series/SeriesServiceImplTest.groovy

@@ -800,6 +800,23 @@ class SeriesServiceImplTest extends Specification {
 
 			result.zagorski?.numbers  == expectedZagorskiNumbers
 			result.zagorski?.price    == expectedInfo.zagorskiPrice
+
+			result.hiddenImageIds?.isEmpty()
+	}
+
+	def 'findFullInfoById() should load hidden images when user can see them'() {
+		given:
+			Integer expectedSeriesId = Random.id()
+			List<Integer> expectedImageIds = Random.listOfIntegers()
+		and:
+			seriesDao.findByIdAsSeriesFullInfo(expectedSeriesId, _ as Integer, _ as String) >>
+				TestObjects.createSeriesFullInfoDto()
+		when:
+			SeriesDto result = service.findFullInfoById(expectedSeriesId, Random.userId(), Random.lang(), true)
+		then:
+			1 * imageService.findBySeriesId(expectedSeriesId, true) >> expectedImageIds
+		and:
+			result?.hiddenImageIds == expectedImageIds
 	}
 
 	//