Update design on WebProfiler

[Nyholm]

Q	A
Bug?	yes
New Feature?	yes
Version	n/a

Our WebProfiler has just been updated with much more information and new design. But there is room for improvements. If we look at @florianpreusner's Guzzle Bundle we see some nice screenshots of how it could look like.

[sagikazarmark]

Doesn't it use the builtin VarDumper? To be honest I am not sure if representing eg. headers as a php data structure is the best we can do.

[fbourigault]

@csarrazi's Guzzle Bundle show us nice screenshots too.

I will start updating the design by introducing Symfony 2.8+ badges count in the toolbar and the menu.

As the 2.7 and 2.8 are really different, what do you think about doing first a small refactoring to avoid writing everywhere {% if constant('Symfony\\Component\\HttpKernel\\Kernel::VERSION_ID') >= 20800 %}! I propose to create 3 templates files:

• webprofiler.html.twig which would be the 2.8+ profiler design.
• webprofiler_legacy.html.twig which would be the 2.7 profiler design.
• webprofiler_common.html.twig which would be the shared design.
  With those 3 templates and the extensive use of blocks, updating the design would be easier.

The right design would be picked by the DI Extension which would set the template tag attribute to the right one.

WDYT?

[dbu]

another option would be to bump the minimal symfony version to 2.8. that is no big jump from 2.7 and will simplify the work here... any objections to that?

[fbourigault]

Would be even better! But does this require a new major release?

[dbu]

imho no. composer.json will make sure it does not get accidentally installed. it should be a new minor version though, so that we can still release bugfixes for 2.7 if somebody really needs one. 1.4 is not yet released, so that would be fine.

[fbourigault]

If everybody agrees, I can do the cleanup and bump the requirement to 2.8+.

[Nyholm]

I agree. Bump it to 2.8 =)

[fbourigault]

For the next improvement, what do you think to have one small line per request and having to click to expand this request?

It would be something like https://github.com/8p/GuzzleBundle and in later improvements, we will be able to push badges on the right like a curl formater button, stopwatch informations, etc..

Once this done, we could improve the per-request inner display.

WDYT?

[Nyholm]

Sound good

[fbourigault]

Here is a wireframe about what I have in mind for the profiler. The 2nd block is what is displayed when you click on the >. The 3rd block is what is displayed when you click on the Show stack button.

I also added cURL button (#108), and the request timing (#135).

[dbu]

this is extremely cool, thanks for your efforts! lets make this happen.

[fbourigault]

@Nyholm if you agree with the layout, I will start working on it to build a functional prototype and then apply styles.

[Nyholm]

I do really like it. Please, go ahead. Im happy to review you PR

[stof]

you should not use the constant to detect the version of the profiler design (btw, the HttpKernel 2.8 is compatible with WebProfilerBundle 2.7 and so with the old design. Too bad when using a separate package for version detection...). You should use the builtin WebProfilerBundle feature to choose the design version (see in doctrineBundle for instance)

[stof]

this would mean having a single template though

[fbourigault]

We already merged the 2.7 drop. It's easier to style with only one profiler as we can rely on 2.8+ CSS styles. It's also easier to develop as you don't have to switch between 2.7 and 2.8. If someone really need to upgrade the bundle, he could also upgrade Symfony to 2.8!

[fbourigault]

Could we close this issue since #146 is merged?

[Nyholm]

Yes! Thank you