Skip to content

Commit 2da5ce2

Browse files
committed
Run with docker process factory
1 parent f435075 commit 2da5ce2

File tree

6 files changed

+12
-13
lines changed

6 files changed

+12
-13
lines changed

.docker/runtime/docker-compose.yml

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
version: '3.8'
2-
31
services:
42
runtime:
53
image: php8appreciate-runtime

composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
],
2323
"require": {
2424
"php": "^8.0",
25-
"php-school/php-workshop": "dev-master"
25+
"php-school/php-workshop": "dev-docker-fixes"
2626
},
2727
"require-dev": {
2828
"phpunit/phpunit": "^9",

composer.lock

+7-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

phpunit.xml

+3
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,7 @@
99
<directory>./test</directory>
1010
<exclude>./test/solutions</exclude>
1111
</testsuite>
12+
<php>
13+
<env name="process_factory" value="docker" force="true" />
14+
</php>
1215
</phpunit>

src/Exercise/ThrowAnExpression.php

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
use PhpParser\Node\Stmt\If_;
1111
use PhpParser\NodeFinder;
1212
use PhpParser\Parser;
13-
use PhpSchool\PhpWorkshop\Environment\CgiTestEnvironment;
1413
use PhpSchool\PhpWorkshop\Exercise\AbstractExercise;
1514
use PhpSchool\PhpWorkshop\Exercise\CgiExercise;
1615
use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;

test/Exercise/ThrowAnExpressionTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public function testThrowingWrongException(): void
3434
self::assertInstanceOf(Success::class, $output->getResults()[1]);
3535

3636
self::assertMatchesRegularExpression(
37-
'/Fatal error: Uncaught Exception: Access denied!/',
37+
'/Fatal error: Uncaught Exception: Access denied!/',
3838
$output->getResults()[0]->getReason()
3939
);
4040

0 commit comments

Comments
 (0)