with latest phpstan version, issue with get_terms() definition

[jcvignoli]

Hi,

The latest PHPStan release seems to check @internal phpdoc comments.

get_terms() has such a comment, meant to address a parameter.

I believe it should be removed, since it makes phpstan to fail as soon as the function is used, with the following error:

 ------ ---------------------------------------- 
  126    Call to internal function get_terms().  
         🪪  function.internal                   
 ------ ------------------------

[szepeviktor]

Thank you for your report!

https://github.com/WordPress/wordpress-develop/blob/0faec7663f7c231a6a2ef442f5d2fc6f3134e50b/src/wp-includes/taxonomy.php#L1304

@johnbillion How could we resolve it?

https://github.com/search?q=repo%3AWordPress%2Fwordpress-develop%20%22%40internal%22&type=code

[szepeviktor]

You could stop using bleeding edge, or disable that feature.

https://github.com/phpstan/phpstan-src/blob/2.1.x/conf/bleedingEdge.neon#L8

[jcvignoli]

Thanks for your reply! Adding

    featureToggles:
        internalTag: false

to my phpstan config did the trick.

May I ask you the rational behind the phpdoc comment

* @internal The `$deprecated` parameter is parsed for backward compatibility only.

I may be wrong, but it doesn't sound to fit into @internal requirement.

[szepeviktor]

John will fix it in core.

[johnbillion]

These were corrected in https://core.trac.wordpress.org/changeset/60249 but 6.9 isn't due until next year so ¯\(ツ)/¯