Allow multiple PHPStan tags with same name #183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course it’s possible; it’s just more verbose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to add two or more PHPStan tags with the same name, such as
@phpstan-template. This issue was brought to my attention in #181, where both@phpstan-templateand@templatewere used to keep both tags. This PR provides changes to the visitor to accommodate this need should it arise in the future.Input format:
[ 'ClassName' => [null, '@phpstan-template' => ['T', 'TKey']], ]which will produce
As there are currently no such cases in the functionMap, there is no need to merge this PR now. I just wanted to leave it here in case we need this change in the future.