Merge pull request #232 from SosthenG/movie-external-ids

Add movie external_ids

Author: wtfzdotnet

lib/Tmdb/Api/Movies.php

@@ -295,4 +295,17 @@ public function getVideos($movie_id, array $parameters = [], array $headers = []
     {
         return $this->get('movie/' . $movie_id . '/videos', $parameters, $headers);
     }
+
+    /**
+     * Get the external ids that we have stored for a movie.
+     *
+     * @param $movie_id
+     * @param array $parameters
+     * @param array $headers
+     * @return mixed
+     */
+    public function getExternalIds($movie_id, array $parameters = [], array $headers = [])
+    {
+        return $this->get('movie/' . $movie_id . '/external_ids', $parameters, $headers);
+    }
 }

lib/Tmdb/Factory/MovieFactory.php

@@ -22,6 +22,7 @@
 use Tmdb\HttpClient\HttpClient;
 use Tmdb\Model\AbstractModel;
 use Tmdb\Model\Common\Country;
+use Tmdb\Model\Common\ExternalIds;
 use Tmdb\Model\Common\GenericCollection;
 use Tmdb\Model\Common\SpokenLanguage;
 use Tmdb\Model\Common\Translation;
@@ -146,6 +147,13 @@ public function create(array $data = []): ?AbstractModel
             }
         }
 
+        /** External ids */
+        if (array_key_exists('external_ids', $data)) {
+            $movie->setExternalIds(
+                $this->hydrate(new ExternalIds(), $data['external_ids'])
+            );
+        }
+
         /** Genres */
         if (array_key_exists('genres', $data)) {
             $movie->setGenres($this->getGenreFactory()->createCollection($data['genres']));

lib/Tmdb/Model/Movie.php

@@ -21,6 +21,7 @@
 use Tmdb\Model\Collection\ResultCollection;
 use Tmdb\Model\Collection\Videos;
 use Tmdb\Model\Common\Country;
+use Tmdb\Model\Common\ExternalIds;
 use Tmdb\Model\Common\GenericCollection;
 use Tmdb\Model\Common\SpokenLanguage;
 use Tmdb\Model\Movie\AlternativeTitle;
@@ -76,6 +77,12 @@ class Movie extends AbstractModel
      * @var CreditsCollection
      */
     protected $credits;
+    /**
+     * External Ids
+     *
+     * @var ExternalIds
+     */
+    private $externalIds;
     /**
      * Images
      *
@@ -238,6 +245,7 @@ public function __construct()
         $this->alternativeTitles = new GenericCollection();
         $this->changes = new GenericCollection();
         $this->credits = new CreditsCollection();
+        $this->externalIds = new ExternalIds();
         $this->images = new Images();
         $this->keywords = new GenericCollection();
         $this->lists = new GenericCollection();
@@ -785,6 +793,26 @@ public function setCredits(CreditsCollection $credits)
         return $this;
     }
 
+    /**
+     * @return ExternalIds
+     */
+    public function getExternalIds()
+    {
+        return $this->externalIds;
+    }
+
+    /**
+     * @param ExternalIds $externalIds
+     * @return $this
+     */
+    public function setExternalIds($externalIds)
+    {
+        $this->externalIds = $externalIds;
+
+        return $this;
+    }
+
+
     /**
      * @return GenericCollection|Keyword[]
      */

lib/Tmdb/Model/Movie/QueryParameter/AppendToResponse.php

@@ -23,6 +23,7 @@
 final class AppendToResponse extends BaseAppendToResponse
 {
     public const ALTERNATIVE_TITLES = 'alternative_titles';
+    public const EXTERNAL_IDS = 'external_ids';
     public const CREDITS = 'credits';
     public const IMAGES = 'images';
     public const KEYWORDS = 'keywords';

lib/Tmdb/Repository/MovieRepository.php

@@ -70,6 +70,7 @@ public function load($id, array $parameters = [], array $headers = [])
             $parameters = array_merge($parameters, [
                 new AppendToResponse([
                     AppendToResponse::ALTERNATIVE_TITLES,
+                    AppendToResponse::EXTERNAL_IDS,
                     AppendToResponse::CHANGES,
                     AppendToResponse::CREDITS,
                     AppendToResponse::IMAGES,
@@ -453,6 +454,22 @@ public function getVideos($id, array $parameters = [], array $headers = [])
         return $movie->getVideos();
     }
 
+    /**
+     * Get the external ids that we have stored for a movie.
+     *
+     * @param $id
+     * @param $parameters
+     * @param $headers
+     * @return null|AbstractModel
+     */
+    public function getExternalIds($id, array $parameters = [], array $headers = [])
+    {
+        $data = $this->getApi()->getExternalIds($id, $this->parseQueryParameters($parameters), $headers);
+        $movie = $this->getFactory()->create(['external_ids' => $data]);
+
+        return $movie->getExternalIds();
+    }
+
     /**
      * @return AlternativeTitleFactory
      */

test/Tmdb/Tests/Api/MoviesTest.php

@@ -40,6 +40,17 @@ public function shouldGetAlternativeTitles()
         $this->assertLastRequestIsWithPathAndMethod('/3/movie/' . self::MOVIE_ID . '/alternative_titles');
     }
 
+    /**
+     * @test
+     */
+    public function shouldGetExternalIds()
+    {
+        $api = $this->getApiWithMockedHttpAdapter();
+
+        $api->getExternalIds(self::MOVIE_ID);
+        $this->assertLastRequestIsWithPathAndMethod('/3/movie/' . self::MOVIE_ID . '/external_ids');
+    }
+
     /**
      * @test
      */

test/Tmdb/Tests/Model/MovieTest.php

@@ -37,6 +37,7 @@ public function shouldConstructMovie()
                 'getSpokenLanguages' => 'Tmdb\Model\Common\GenericCollection',
                 'getAlternativeTitles' => 'Tmdb\Model\Common\GenericCollection',
                 'getChanges' => 'Tmdb\Model\Common\GenericCollection',
+                'getExternalIds' => 'Tmdb\Model\Common\ExternalIds',
                 'getCredits' => 'Tmdb\Model\Collection\CreditsCollection',
                 'getImages' => 'Tmdb\Model\Collection\Images',
                 'getKeywords' => 'Tmdb\Model\Common\GenericCollection',

test/Tmdb/Tests/Repository/MovieRepositoryTest.php

@@ -30,7 +30,7 @@ public function shouldLoadMovie()
         $repository->load(self::MOVIE_ID);
         $this->assertLastRequestIsWithPathAndMethod('/3/movie/' . self::MOVIE_ID);
         $this->assertRequestHasQueryParameters([
-            'append_to_response' => 'alternative_titles,changes,credits,images,keywords,lists,release_dates,reviews,similar,recommendations,translations,videos'
+            'append_to_response' => 'alternative_titles,external_ids,changes,credits,images,keywords,lists,release_dates,reviews,similar,recommendations,translations,videos'
         ]);
     }
 
@@ -45,6 +45,17 @@ public function shouldGetAlternativeTitles()
         $this->assertLastRequestIsWithPathAndMethod('/3/movie/' . self::MOVIE_ID . '/alternative_titles');
     }
 
+    /**
+     * @test
+     */
+    public function shouldGetExternalIds()
+    {
+        $repository = $this->getRepositoryWithMockedHttpAdapter();
+
+        $repository->getExternalIds(self::MOVIE_ID);
+        $this->assertLastRequestIsWithPathAndMethod('/3/movie/' . self::MOVIE_ID . '/external_ids');
+    }
+
     /**
      * @test
      */