Fix implicitly marking parameter as nullable deprecation for PHP 8.4 (#280)

* fix phpstan errors for php 8.4 and cleanup php requirements in composer.json

* add phpstan error with people as wrong return type to the baseline

Author: romanpravda

composer.json

@@ -31,7 +31,7 @@
     "license": "MIT",
     "name": "php-tmdb/api",
     "require": {
-        "php": "^7.3 || ^7.4 || ^8.0 || ^8.1",
+        "php": "^7.3 || ^8.0",
         "ext-json": "*",
         "symfony/options-resolver": "^4.4 || ^5 || ^6",
         "psr/cache": "^1 || ^2 || ^3",

lib/Tmdb/Event/HydrationEvent.php

@@ -111,7 +111,7 @@ public function getLastRequest(): ?RequestInterface
      * @param RequestInterface|null $lastRequest
      * @return self
      */
-    public function setLastRequest(RequestInterface $lastRequest = null): HydrationEvent
+    public function setLastRequest(?RequestInterface $lastRequest = null): HydrationEvent
     {
         $this->lastRequest = $lastRequest;
 
@@ -130,7 +130,7 @@ public function getLastResponse(): ?ResponseInterface
      * @param ResponseInterface|null $lastResponse
      * @return self
      */
-    public function setLastResponse(ResponseInterface $lastResponse = null): HydrationEvent
+    public function setLastResponse(?ResponseInterface $lastResponse = null): HydrationEvent
     {
         $this->lastResponse = $lastResponse;
 

lib/Tmdb/Event/Listener/Logger/LogApiErrorListener.php

@@ -40,7 +40,7 @@ class LogApiErrorListener
      * @param LoggerInterface $logger
      * @param TmdbApiExceptionFormatterInterface|null $formatter
      */
-    public function __construct(LoggerInterface $logger, TmdbApiExceptionFormatterInterface $formatter = null)
+    public function __construct(LoggerInterface $logger, ?TmdbApiExceptionFormatterInterface $formatter = null)
     {
         $this->logger = $logger;
         $this->formatter = $formatter ?: new SimpleTmdbApiExceptionFormatter();

lib/Tmdb/Event/Listener/Logger/LogHttpMessageListener.php

@@ -44,7 +44,7 @@ class LogHttpMessageListener
      * @param LoggerInterface $logger
      * @param HttpMessageFormatterInterface|null $formatter
      */
-    public function __construct(LoggerInterface $logger, HttpMessageFormatterInterface $formatter = null)
+    public function __construct(LoggerInterface $logger, ?HttpMessageFormatterInterface $formatter = null)
     {
         $this->logger = $logger;
         $this->formatter = $formatter ?: new SimpleHttpMessageFormatter();

lib/Tmdb/Event/Listener/Logger/LogHydrationListener.php

@@ -49,7 +49,7 @@ class LogHydrationListener
      */
     public function __construct(
         LoggerInterface $logger,
-        HydrationFormatterInterface $formatter = null,
+        ?HydrationFormatterInterface $formatter = null,
         bool $withData = false
     ) {
         $this->logger = $logger;

lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

@@ -23,7 +23,7 @@
 class SessionTokenRequestListener
 {
     /**
-     * @var string|SessionBearerToken|GuestSessionToken
+     * @var SessionToken
      */
     private $token;
 

lib/Tmdb/Event/Listener/Request/UserAgentRequestListener.php

@@ -28,7 +28,7 @@ class UserAgentRequestListener
      * UserAgentRequestListener constructor.
      * @param string|null $userAgent
      */
-    public function __construct(string $userAgent = null)
+    public function __construct(?string $userAgent = null)
     {
         $this->userAgent = $userAgent ?? sprintf('php-tmdb/api/%s', Client::VERSION);
     }

lib/Tmdb/Event/RequestEvent.php

@@ -45,7 +45,7 @@ class RequestEvent extends StoppableEvent implements LoggableHttpEventInterface
      * @param RequestInterface $request
      * @param SessionToken|null $sessionToken
      */
-    public function __construct(RequestInterface $request, SessionToken $sessionToken = null)
+    public function __construct(RequestInterface $request, ?SessionToken $sessionToken = null)
     {
         $this->request = $request;
         $this->sessionToken = $sessionToken;
@@ -109,7 +109,7 @@ public function getSessionToken(): ?SessionToken
      * @param SessionToken|null $sessionToken
      * @return self
      */
-    public function setSessionToken(SessionToken $sessionToken = null): RequestEvent
+    public function setSessionToken(?SessionToken $sessionToken = null): RequestEvent
     {
         $this->sessionToken = $sessionToken;
 

lib/Tmdb/Exception/TmdbApiException.php

@@ -81,9 +81,9 @@ class TmdbApiException extends Exception
     public function __construct(
         int $code,
         string $message,
-        RequestInterface $request = null,
-        ResponseInterface $response = null,
-        Exception $previous = null
+        ?RequestInterface $request = null,
+        ?ResponseInterface $response = null,
+        ?Exception $previous = null
     ) {
         parent::__construct($message, $code, $previous);
 

lib/Tmdb/HttpClient/HttpClient.php

@@ -197,7 +197,7 @@ public function getPsr14EventDispatcher(): EventDispatcherInterface
      * @param string|null $key
      * @return array|mixed
      */
-    public function getOptions(string $key = null)
+    public function getOptions(?string $key = null)
     {
         if ($key) {
             return isset($this->options[$key]) ? $this->options[$key] : null;