Skip to content

Commit 9d3f2e0

Browse files
authored
Merge pull request #163 from yukoff/hotfix/2.1/fix-incompatible-declarations
Fix fatal error on php-nightly
2 parents 949387f + 715e972 commit 9d3f2e0

File tree

5 files changed

+14
-6
lines changed

5 files changed

+14
-6
lines changed

.travis.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
sudo: false
22
language: php
33

4+
php:
5+
- 5.6
6+
- nightly
7+
- hhvm
8+
49
before_script:
510
- composer self-update
611
- if [ "$SF_EVT_DISPATCHER_VERSION" != "" ]; then composer require --no-update symfony/event-dispatcher:${SF_EVT_DISPATCHER_VERSION}; fi;

lib/Tmdb/Factory/People/CastFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ class CastFactory extends PeopleFactory
2323
{
2424
/**
2525
* {@inheritdoc}
26-
* @param \Tmdb\Model\Person\CastMember $person
26+
* @param \Tmdb\Model\Person\CastMember|null $person
2727
*/
28-
public function createCollection(array $data = [], $person = null)
28+
public function createCollection(array $data = [], $person = null, $collection = null)
2929
{
3030
$collection = new Cast();
3131

lib/Tmdb/Factory/People/CrewFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ class CrewFactory extends PeopleFactory
2323
{
2424
/**
2525
* {@inheritdoc}
26-
* @param \Tmdb\Model\Person\CrewMember $person
26+
* @param \Tmdb\Model\Person\CrewMember|null $person
2727
*/
28-
public function createCollection(array $data = [], $person = null)
28+
public function createCollection(array $data = [], $person = null, $collection = null)
2929
{
3030
$collection = new Crew();
3131

lib/Tmdb/Factory/People/GuestStarFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ class GuestStarFactory extends PeopleFactory
2323
{
2424
/**
2525
* {@inheritdoc}
26-
* @param \Tmdb\Model\Person\CastMember $person
26+
* @param \Tmdb\Model\Person\CastMember|null $person
2727
*/
28-
public function createCollection(array $data = [], $person = null)
28+
public function createCollection(array $data = [], $person = null, $collection = null)
2929
{
3030
$collection = new GuestStars();
3131

lib/Tmdb/Factory/PeopleFactory.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
use Tmdb\HttpClient\HttpClient;
1818
use Tmdb\Model\Collection\People;
1919
use Tmdb\Model\Common\ExternalIds;
20+
use Tmdb\Model\Common\GenericCollection;
2021
use Tmdb\Model\Person\CastMember;
2122
use Tmdb\Model\Person\CrewMember;
2223
use Tmdb\Model\Person;
@@ -165,6 +166,8 @@ protected function getPosterImageForCredit($posterPath)
165166

166167
/**
167168
* {@inheritdoc}
169+
* @param Person\AbstractMember|null $person
170+
* @param GenericCollection|null $collection
168171
*/
169172
public function createCollection(array $data = [], $person = null, $collection = null)
170173
{

0 commit comments

Comments
 (0)