Fixed fetching instantclient

shivammathur · shivammathur · commit 8e5eccbcbc83 · 2025-08-27T02:08:29.000+05:30
diff --git a/extension/BuildPhpExtension/private/Add-OciSdk.ps1 b/extension/BuildPhpExtension/private/Add-OciSdk.ps1
@@ -16,7 +16,7 @@ Function Add-OciSdk {
         $suffix = if ($Config.arch -eq "x64") {"windows"} else {"nt"}
         @('sdk', 'basic') | ForEach-Object {
             $url = "https://download.oracle.com/otn_software/nt/instantclient/instantclient-$_-$suffix.zip"
-            Get-File -Url -OutFile "instantclient-$_.zip"
+            Get-File -Url $url -OutFile "instantclient-$_.zip"
             Expand-Archive -Path "instantclient-$_.zip" -DestinationPath "../deps" -Force
         }
         Copy-Item ../deps/instantclient_*/sdk/* -Destination "../deps" -Recurse -Force

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ Function Add-OciSdk {`
`16`	`16`	`$suffix = if ($Config.arch -eq "x64") {"windows"} else {"nt"}`
`17`	`17`	`@('sdk', 'basic') \| ForEach-Object {`
`18`	`18`	`$url = "https://download.oracle.com/otn_software/nt/instantclient/instantclient-$_-$suffix.zip"`
`19`		`- Get-File -Url -OutFile "instantclient-$_.zip"`
	`19`	`+ Get-File -Url $url -OutFile "instantclient-$_.zip"`
`20`	`20`	`Expand-Archive -Path "instantclient-$_.zip" -DestinationPath "../deps" -Force`
`21`	`21`	`}`
`22`	`22`	`Copy-Item ../deps/instantclient_/sdk/ -Destination "../deps" -Recurse -Force`